Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql_input: Add merge_results feature to SQL Input package #6922

Merged
merged 7 commits into from Jul 14, 2023

Conversation

ishleenk17
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR adds the merge_results feature to SQL Input Package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Two queries for MYSQL
Screenshot 2023-07-11 at 7 24 19 PM

Metrics of both queries merged in single event
Screenshot 2023-07-11 at 7 12 51 PM

@ishleenk17 ishleenk17 self-assigned this Jul 11, 2023
@ishleenk17 ishleenk17 requested a review from a team as a code owner July 11, 2023 18:07
@elasticmachine
Copy link

elasticmachine commented Jul 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-14T09:23:39.255+0000

  • Duration: 16 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

packages/sql_input/agent/input/input.yml.hbs Outdated Show resolved Hide resolved
packages/sql_input/docs/README.md Outdated Show resolved Hide resolved
packages/sql_input/manifest.yml Outdated Show resolved Hide resolved
packages/sql_input/manifest.yml Outdated Show resolved Hide resolved
@shmsr shmsr changed the title Add merge result feature to sql Input package Add merge result feature to SQL Input package Jul 12, 2023
@shmsr shmsr changed the title Add merge result feature to SQL Input package sql_input: Add merge result feature to SQL Input package Jul 12, 2023
ishleenk17 and others added 4 commits July 12, 2023 10:47
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@ishleenk17
Copy link
Contributor Author

/test

@shmsr shmsr changed the title sql_input: Add merge result feature to SQL Input package sql_input: Add merge_results feature to SQL Input package Jul 12, 2023
packages/sql_input/manifest.yml Outdated Show resolved Hide resolved
packages/sql_input/manifest.yml Outdated Show resolved Hide resolved
packages/sql_input/changelog.yml Outdated Show resolved Hide resolved
packages/sql_input/manifest.yml Outdated Show resolved Hide resolved
packages/sql_input/docs/README.md Show resolved Hide resolved
@muthu-mps muthu-mps self-requested a review July 13, 2023 13:26
packages/sql_input/manifest.yml Outdated Show resolved Hide resolved
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@ishleenk17
Copy link
Contributor Author

/test

@ishleenk17 ishleenk17 merged commit 0e17319 into elastic:main Jul 14, 2023
4 checks passed
harnish-elastic pushed a commit to harnish-elastic/integrations that referenced this pull request Jul 14, 2023
…6922)

* Add merge result feature to sql Input package

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/agent/input/input.yml.hbs

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/docs/README.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Address review comments

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

---------

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@elasticmachine
Copy link

Package sql - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=sql

harnish-elastic added a commit that referenced this pull request Jul 21, 2023
…6962)

* Add merge result feature to sql Input package

* Update packages/sql_input/manifest.yml



* Update packages/sql_input/manifest.yml



* Update packages/sql_input/agent/input/input.yml.hbs



* Update packages/sql_input/docs/README.md



* Address review comments

* Update packages/sql_input/manifest.yml



---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
gizas pushed a commit that referenced this pull request Sep 5, 2023
* Add merge result feature to sql Input package

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/agent/input/input.yml.hbs

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/docs/README.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Address review comments

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

---------

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
gizas pushed a commit that referenced this pull request Sep 5, 2023
…6962)

* Add merge result feature to sql Input package

* Update packages/sql_input/manifest.yml



* Update packages/sql_input/manifest.yml



* Update packages/sql_input/agent/input/input.yml.hbs



* Update packages/sql_input/docs/README.md



* Address review comments

* Update packages/sql_input/manifest.yml



---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL Input Package] Support merge_results in SQL Input Package
5 participants