Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][AWS] Migrate AWS VPC Flow dashboard visualizations to lens #6962

Merged
merged 3 commits into from Jul 21, 2023
Merged

[O11y][AWS] Migrate AWS VPC Flow dashboard visualizations to lens #6962

merged 3 commits into from Jul 21, 2023

Conversation

harnish-elastic
Copy link
Contributor

Urgency

  • Normal

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate AWS VPC visualizations to the lens in the current Kibana version 8.8.1 itself.

  • Statistics for AWS VPC Lens migration:

AWS VPC Dashboards Before Migration       After Migration      
  Maps Search Lens Visualization Maps Search Lens Visualization
[Logs AWS] VPC Flow Log Overview 1 1 0 3 1 1 3 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.

Related issues

Meta issue

@harnish-elastic harnish-elastic self-assigned this Jul 14, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review July 14, 2023 10:51
@harnish-elastic harnish-elastic requested review from a team as code owners July 14, 2023 10:51
@harnish-elastic harnish-elastic mentioned this pull request Jul 14, 2023
Closed
5 tasks
@ishleenk17 @shmsr @harnish-elastic
sql_input: Add merge_results feature to SQL Input package (elastic#…
6050342 
…6922)

* Add merge result feature to sql Input package

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/agent/input/input.yml.hbs

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Update packages/sql_input/docs/README.md

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* Address review comments

* Update packages/sql_input/manifest.yml

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

---------

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@harnish-elastic harnish-elastic requested a review from a team as a code owner July 14, 2023 11:35
@elasticmachine
Copy link

elasticmachine commented Jul 14, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-21T11:34:38.587+0000

  • Duration: 53 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 4
Total 210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 14, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍
Classes 94.444% (17/18) 👍
Methods 85.953% (257/299) 👍
Lines 86.011% (7501/8721) 👍
Conditionals 100.0% (0/0) 💚

@harnish-elastic harnish-elastic removed the request for review from a team July 14, 2023 11:38
@rajvi-patel-22 rajvi-patel-22 self-requested a review July 17, 2023 06:24
rajvi-patel-22
rajvi-patel-22 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

drewdaemon
drewdaemon approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
28045f1 
…into lens_migration-aws-vpcflow

Conflicts:
	packages/aws/changelog.yml
	packages/aws/manifest.yml
@harnish-elastic
Copy link
Contributor Author

/test

@harnish-elastic harnish-elastic merged commit 1e9ef8b into elastic:main Jul 21, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 1.50.4 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
@harnish-elastic @ishleenk17
@shmsr @gizas
sql_input: Add merge_results feature to SQL Input package (#6922) (#…
8494345 
…6962)

* Add merge result feature to sql Input package

* Update packages/sql_input/manifest.yml



* Update packages/sql_input/manifest.yml



* Update packages/sql_input/agent/input/input.yml.hbs



* Update packages/sql_input/docs/README.md



* Address review comments

* Update packages/sql_input/manifest.yml



---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@rajvi-patel-22 rajvi-patel-22 rajvi-patel-22 approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][AWS VPC] Lens Migration
6 participants
@harnish-elastic @elasticmachine @drewdaemon @kaiyan-sheng @rajvi-patel-22 @ishleenk17