Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Istio] Enable TSDB by default #7030

Merged
merged 2 commits into from Aug 1, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Enable TSDB by default for all metrics data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6567.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m mentioned this pull request Jul 20, 2023
4 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-20T09:08:36.827+0000

  • Duration: 17 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 2.767
Classes 100.0% (3/3) 💚 2.767
Methods 90.0% (27/30) 👎 -2.172
Lines 97.472% (347/356) 👍 6.322
Conditionals 100.0% (0/0) 💚

Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awaiting code owner approval.

@gsantoro
Copy link
Contributor

I haven't tested how it works since I am not familiar with TSDB. Code changes look good as far as I know

@constanca-m constanca-m merged commit 664e38f into elastic:main Aug 1, 2023
4 checks passed
@constanca-m constanca-m deleted the istio-enable-tsdb branch August 1, 2023 06:40
@elasticmachine
Copy link

Package istio - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=istio

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Enable TSDB by default.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

* Update changelog.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

---------

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants