New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] [Container_instance] Add dimensions and metric_type metadata for the container_instance data_stream #7127
[Azure] [Container_instance] Add dimensions and metric_type metadata for the container_instance data_stream #7127
Conversation
…ta_stream Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@zmoog I couldn't find those fields - https://github.com/elastic/integrations/blob/main/packages/azure_metrics/data_stream/container_instance/fields/fields.yml#L1 could you please check if this field is not added by mistake? |
🌐 Coverage report
|
Yep, I'll check it out! |
packages/azure_metrics/data_stream/container_instance/fields/package-fields.yml
Show resolved
Hide resolved
packages/azure_metrics/changelog.yml
Outdated
changes: | ||
- description: Add dimension and metric_type metadata to the container_instance data_stream | ||
type: enhancement | ||
link: https://github.com/elastic/integrations/pull/5123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the PR link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done - 7a77aa7
packages/azure_metrics/changelog.yml
Outdated
@@ -1,3 +1,8 @@ | |||
- version: "1.0.17" | |||
changes: | |||
- description: Add dimension and metric_type metadata to the container_instance data_stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- description: Add dimension and metric_type metadata to the container_instance data_stream | |
- description: Add dimension and metric_type metadata to the container_instance datastream |
packages/azure_metrics/data_stream/container_instance/fields/package-fields.yml
Show resolved
Hide resolved
@@ -1,6 +1,6 @@ | |||
name: azure_metrics | |||
title: Azure Resource Metrics | |||
version: 1.0.16 | |||
version: 1.0.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 1.1.0
? Any specific reason ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no specific reason, I did it similarly to the AWS package, also I've noticed that previous changes in this package were also added with 1.0.X
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling TSDB seems worth a bump to the minor version, but I have no strong opinions. I'll leave the decision to you, TSDB folks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
packages/azure_metrics/data_stream/container_instance/fields/package-fields.yml
Show resolved
Hide resolved
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@bturquet can you help us getting these reviewed? We have a long queue of Azure packages waiting on it. Merci |
@@ -1,6 +1,6 @@ | |||
name: azure_metrics | |||
title: Azure Resource Metrics | |||
version: 1.0.16 | |||
version: 1.0.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling TSDB seems worth a bump to the minor version, but I have no strong opinions. I'll leave the decision to you, TSDB folks.
Package azure_metrics - 1.0.17 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
…for the container_instance data_stream (#7127) * add dimensions and metric_type metadata for the container_instance data_stream Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * address review comments Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add agent.id field Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * extend azure.container_instance field Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
What does this PR do?
avg
cloud.region
azure.resource.id
- this field includesazure.subscription_id
,azure.resource.group
,azure.resource.name
, format:azure.dimensions.container_name
- this field is not available for 2 metrics:network_bytes_transmitted_per_second.avg
andnetwork_bytes_received_per_second.avg
azure.timegrain
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots