Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Add missing fields definition for ec2 data stream #7300

Closed
wants to merge 5 commits into from

Conversation

kaiyan-sheng
Copy link
Contributor

What does this PR do?

  1. add missing fields definitions into fields.yml for ec2 data stream
  2. run elastic-package lint and elastic-package format
  3. fix ec2 dashboard to use the correct field name

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested review from a team as code owners August 7, 2023 20:39
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 7, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 7, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-09T22:15:57.952+0000

  • Duration: 17 min 3 sec

Steps errors 3

Expand to view the steps failures

Test integration: aws
  • Took 3 min 21 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kaiyan-sheng
Copy link
Contributor Author

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18)
Classes 94.444% (17/18)
Methods 96.347% (211/219)
Lines 86.011% (7501/8721)
Conditionals 100.0% (0/0) 💚

@constanca-m
Copy link
Contributor

Thanks @kaiyan-sheng , I checked again and the EC2 fields seem to be the right ones now

@constanca-m
Copy link
Contributor

Hey @kaiyan-sheng , any updates on this?

@kaiyan-sheng
Copy link
Contributor Author

@constanca-m Sorry for the delay! I couldn't figure out why the CI keeps failing so I created #7425 to just focus on the EC2 part of the changes. I will close this PR and let's move it to the new one :)

@kaiyan-sheng kaiyan-sheng deleted the ec2_fields branch August 21, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants