Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Add missing fields definition for ec2 data stream #7425

Merged
merged 8 commits into from Aug 21, 2023

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 16, 2023

What does this PR do?

  1. add missing fields definitions into fields.yml for ec2 data stream
  2. fix ec2 dashboard to use the correct field name

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

elasticmachine commented Aug 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-21T14:17:37.846+0000

  • Duration: 56 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 208
Skipped 4
Total 212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍
Classes 94.444% (17/18) 👍
Methods 85.953% (257/299) 👍
Lines 86.024% (7509/8729) 👍
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review August 21, 2023 13:51
@kaiyan-sheng kaiyan-sheng requested review from a team as code owners August 21, 2023 13:51
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 21, 2023
@constanca-m
Copy link
Contributor

/test

@kaiyan-sheng kaiyan-sheng merged commit f597c30 into elastic:main Aug 21, 2023
4 checks passed
@kaiyan-sheng kaiyan-sheng deleted the ec2_bug branch August 21, 2023 15:37
@elasticmachine
Copy link

Package aws - 1.53.3 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants