Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][CouchDB] Resolve the conflicts in host.ip field #7495

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[O11y][CouchDB] Resolve the conflicts in host.ip field #7495

merged 2 commits into from
Sep 5, 2023

Conversation

milan-elastic
Copy link
Contributor

  • Bug

What does this PR do?

  • Added host.ip field in ecs.yml to avoid field conflicts for users.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@milan-elastic milan-elastic requested a review from a team as a code owner August 22, 2023 11:21
@milan-elastic milan-elastic self-assigned this Aug 22, 2023
@milan-elastic milan-elastic added Integration:couchdb CouchDB bugfix Pull request that fixes a bug issue labels Aug 22, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-22T11:25:52.633+0000

  • Duration: 14 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (7/7) 💚 54.545
Lines 94.175% (194/206) 👎 -5.825
Conditionals 100.0% (0/0) 💚

ali786XI
ali786XI approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muthu-mps
Copy link
Contributor

Do we have plans to update the troubleshooting guide similar to other PR's ?

@milan-elastic
Copy link
Contributor Author

milan-elastic commented Aug 29, 2023 •
edited
Loading

Do we have plans to update the troubleshooting guide similar to other PR's ?

@muthu-mps For the couchDB TSDB is already enabled, we don't have the exact reindexing steps while TSDB is enabled, So for now it is not updated. When we'll have clarity on the steps then we can plan to include it. For more information, Please have a look at this issue.

muthu-mps
muthu-mps approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@milan-elastic milan-elastic merged commit ba743dd into elastic:main Sep 5, 2023
1 check passed
@elasticmachine
Copy link

Package couchdb - 0.7.1 containing this change is available at https://epr.elastic.co/search?package=couchdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthu-mps muthu-mps muthu-mps approved these changes

@ali786XI ali786XI ali786XI approved these changes

Assignees

@milan-elastic milan-elastic

Labels
bugfix Pull request that fixes a bug issue Integration:couchdb CouchDB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][CouchDB] Conflicts in host.ip field
4 participants
@milan-elastic @elasticmachine @muthu-mps @ali786XI