Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][WebSphere Application Server] Update dashboards, visualizations and screenshots #7510

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[O11y][WebSphere Application Server] Update dashboards, visualizations and screenshots #7510

merged 1 commit into from
Sep 6, 2023

Conversation

ali786XI
Copy link
Contributor

@ali786XI ali786XI commented Aug 23, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Replaced the Median aggregation used in visualizations to Last Value to make them meaningful
  • Disbaled the Group Others toggle
  • Updated Y axis labels wherever required
  • Updated the filters used in visualizations
  • Changed the Rank By setting to use the proper value instead of Alphabetical
  • Applied sorting on column Total Threads in visualization of Threadpool dashboard
  • Updated the name of the visualization in Saved Library to make it match with actual name
  • Updated screenshots

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

Screenshots

[Metrics WebSphere Application Server] JDBC

image

[Metrics WebSphere Application Server] Servlet

image

[Metrics WebSphere Application Server] Session Manager

image

[Metrics WebSphere Application Server] Threadpool

image

@ali786XI ali786XI added enhancement New feature or request Integration:websphere_application_server WebSphere Application Server labels Aug 23, 2023
@ali786XI ali786XI requested a review from a team as a code owner August 23, 2023 15:20
@ali786XI ali786XI self-assigned this Aug 23, 2023
@ali786XI ali786XI marked this pull request as draft August 23, 2023 15:20
@ali786XI ali786XI force-pushed the websphere_application_server_update_dashboards branch from 930e8a4 to f8a6b54 Compare August 23, 2023 15:25
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-04T15:15:30.724+0000

  • Duration: 31 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (28/28) 💚
Lines 100.0% (488/488) 💚
Conditionals 100.0% (0/0) 💚

@ali786XI ali786XI changed the title Update dashboards, visualizations and screenshots [O11y][WebSphere Application Server] Update dashboards, visualizations and screenshots Aug 23, 2023
@ali786XI ali786XI marked this pull request as ready for review August 24, 2023 05:57
rajvi-patel-22
rajvi-patel-22 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ali786XI ali786XI closed this Sep 4, 2023
@ali786XI ali786XI force-pushed the websphere_application_server_update_dashboards branch from 6b572ae to b9623f8 Compare September 4, 2023 13:36
@ali786XI ali786XI reopened this Sep 4, 2023
muthu-mps
muthu-mps approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ali786XI ali786XI merged commit d56933c into elastic:main Sep 6, 2023
4 checks passed
@elasticmachine
Copy link

Package websphere_application_server - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthu-mps muthu-mps muthu-mps approved these changes

@rajvi-patel-22 rajvi-patel-22 rajvi-patel-22 approved these changes

Assignees

@ali786XI ali786XI

Labels
enhancement New feature or request Integration:websphere_application_server WebSphere Application Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][WebSphere Application Server] Update aggregations and filters used in dashboards
4 participants
@ali786XI @elasticmachine @muthu-mps @rajvi-patel-22