-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ProblemChild] Two Detection Rules Querying Invalid Indices #7521
[ProblemChild] Two Detection Rules Querying Invalid Indices #7521
Conversation
…/github.com/MakoWish/integrations into rule_tuning_problem_child_probability_score
…/github.com/MakoWish/integrations into rule_tuning_problem_child_probability_score
…/github.com/MakoWish/integrations into rule_tuning_problem_child_probability_score
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM - we are down as CODEOWNERS
of this package. No specific ML changes here but LGTM to clear the ml-ui approval.
Hi, thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to keep the pattern as specific as possible, so -*
instead of *
. LGTM if you can resolve the version and manifest conflicts. Thanks for trying the package out, and for the PRs!
packages/problemchild/kibana/security_rule/34184d4e-ef61-477b-8d76-5c93448c29bf.json
Outdated
Show resolved
Hide resolved
packages/problemchild/kibana/security_rule/9a2e372a-cbeb-4ad6-a288-017ef086324c.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Also, can we consolidate all these bug /broken link fixes into a single PR resulting in a single patch version bump? Thanks! |
Consolidating into #7618 |
* Update docs with new blog link * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Consolidate #7521 and #7577 into #7618 --------- Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
* Update docs with new blog link * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Consolidate #7521 and #7577 into #7618 --------- Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
What does this PR do?
Two of the Detection Rules supplied in the ProblemChild Integration look for
logs-endpoint.events.process.*
, but that final period is invalid and will not match an Elastic Endpoint index. These indices are named (using default as an example)logs-endpoint.events.process-default
, so this should be eitherlogs-endpoint.events.process*
orlogs-endpoint.events.process-*
.Checklist
How to test this PR locally
Related issues
Screenshots