Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes #7618

Merged
merged 11 commits into from
Sep 1, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Aug 30, 2023

Type of change

  • Enhancement

What does this PR do?

This PR updates the blog post link in the ProblemChild integration's docs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@MakoWish MakoWish marked this pull request as ready for review August 30, 2023 17:38
@MakoWish MakoWish requested review from a team as code owners August 30, 2023 17:38
@MakoWish MakoWish changed the title Problem child documentation link [ProblemChild] Update Blog Post Link in Docs Aug 30, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-31T16:32:09.847+0000

  • Duration: 14 min 51 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@susan-shu-c
Copy link
Member

/test

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ML

MakoWish and others added 4 commits August 31, 2023 10:17
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
@@ -351,7 +351,7 @@ processors:
}
if:
ctx.containsKey('problemchild') && ctx['problemchild'].containsKey('prediction')
&& ctx['problemchild']['prediction'] == 0
&& ctx['problemchild']['prediction'] == '0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajosh0504 does this look good? The rest of these changes are good to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good!

Copy link
Contributor

@ajosh0504 ajosh0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks, @MakoWish! 🚀

@@ -351,7 +351,7 @@ processors:
}
if:
ctx.containsKey('problemchild') && ctx['problemchild'].containsKey('prediction')
&& ctx['problemchild']['prediction'] == 0
&& ctx['problemchild']['prediction'] == '0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good!

@susan-shu-c susan-shu-c merged commit 78d8776 into elastic:main Sep 1, 2023
3 checks passed
@elasticmachine
Copy link

Package problemchild - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=problemchild

@MakoWish MakoWish changed the title [ProblemChild] Update Blog Post Link in Docs [ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes Sep 1, 2023
@MakoWish MakoWish deleted the problem_child_documentation_link branch September 1, 2023 15:21
gizas pushed a commit that referenced this pull request Sep 5, 2023
* Update docs with new blog link

* Commit changes from code review

Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>

* Commit changes from code review

Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>

* Consolidate #7521 and #7577 into #7618

---------

Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ProblemChild] Update Blog Post Link in README
5 participants