-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes #7618
[ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes #7618
Conversation
…/MakoWish/integrations into problem_child_documentation_link
…/MakoWish/integrations into problem_child_documentation_link
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ML
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
…/MakoWish/integrations into problem_child_documentation_link
@@ -351,7 +351,7 @@ processors: | |||
} | |||
if: | |||
ctx.containsKey('problemchild') && ctx['problemchild'].containsKey('prediction') | |||
&& ctx['problemchild']['prediction'] == 0 | |||
&& ctx['problemchild']['prediction'] == '0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajosh0504 does this look good? The rest of these changes are good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. Thanks, @MakoWish! 🚀
@@ -351,7 +351,7 @@ processors: | |||
} | |||
if: | |||
ctx.containsKey('problemchild') && ctx['problemchild'].containsKey('prediction') | |||
&& ctx['problemchild']['prediction'] == 0 | |||
&& ctx['problemchild']['prediction'] == '0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep this looks good!
Package problemchild - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=problemchild |
* Update docs with new blog link * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Consolidate #7521 and #7577 into #7618 --------- Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Type of change
What does this PR do?
This PR updates the blog post link in the ProblemChild integration's docs.
Checklist
changelog.yml
file.manifest.yml
file.Related issues