Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Azure Metrics] Migrate Compute VM Guest ASP.NET & Sql Server dashboard to lens #7562

Merged
merged 3 commits into from
Aug 29, 2023
Merged

[O11y][Azure Metrics] Migrate Compute VM Guest ASP.NET & Sql Server dashboard to lens #7562

merged 3 commits into from
Aug 29, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Compute VM Guest ASP.NET & Sql Server visualizations to the lens in the current Kibana version 8.4.0 itself.

  • Statistics for Compute VM Guest ASP.NET & Sql Server Lens migration:

Migration stats

  Before Migration     After Migration    
  Lens Visualization Old Input Controls Lens Visualization New control panels
[Azure Metrics] Compute VM Guest ASP.NET & Sql Server 0 7 1 7 0 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Screenshot

Before Migration
image

After Migration
image

@rajvi-patel-22 rajvi-patel-22 self-assigned this Aug 28, 2023
@rajvi-patel-22 rajvi-patel-22 added enhancement New feature or request dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:azure_metrics Azure Resource Metrics labels Aug 28, 2023
@rajvi-patel-22 rajvi-patel-22 requested review from kush-elastic and a team August 28, 2023 10:40
@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-29T06:27:28.118+0000

  • Duration: 15 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👎 -14.493
Lines 100.0% (21/21) 💚 4.0
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review August 28, 2023 10:48
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner August 28, 2023 10:48
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Aug 28, 2023
Closed
8 tasks
kush-elastic
kush-elastic approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 3676d6e into elastic:main Aug 29, 2023
4 checks passed
@elasticmachine
Copy link

Package azure_metrics - 1.0.30 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

gizas pushed a commit that referenced this pull request Sep 5, 2023
@rajvi-patel-22 @gizas
[O11y][Azure Metrics] Migrate Compute VM Guest ASP.NET & Sql Server d…
d3df265 
…ashboard to lens (#7562)

* Migrate Compute VM Guest ASP.NET & Sql Server dashboard to lens

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:azure_metrics Azure Resource Metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajvi-patel-22 @elasticmachine @zmoog @kush-elastic