-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[integrations][Confluence] - Fixed timestamp handling in httpjson cursor #7647
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Did you validate it manually? If not, maybe we could add a system test.
@kcreddy tested it manually by simulating an exact server response. The sample response logs were provided by the client. |
🌐 Coverage report
|
1 similar comment
🌐 Coverage report
|
Package atlassian_confluence - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=atlassian_confluence |
…sor (#7647) * bugfix for confluence package timestamp handling * updated changelog
Type of change
What does this PR do?
The .first_event.CreationDate field was containing invalid unix epoch timestamp values due to the response value of CreationDate being interpreted as a float64. This caused successive pagination request failures. To address this, inserted a small clause to cast it to an int before storing it in the cursor.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
This is related to an SDH
Screenshots