[integrations][Confluence] - Fixed timestamp handling in httpjson cursor #7647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
kcreddy
approved these changes
Sep 4, 2023
@kcreddy tested it manually by simulating an exact server response. The sample response logs were provided by the client. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
1 similar comment
🌐 Coverage report
|
|
Package atlassian_confluence - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=atlassian_confluence |
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
…sor (#7647) * bugfix for confluence package timestamp handling * updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
The .first_event.CreationDate field was containing invalid unix epoch timestamp values due to the response value of CreationDate being interpreted as a float64. This caused successive pagination request failures. To address this, inserted a small clause to cast it to an int before storing it in the cursor.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
This is related to an SDH
Screenshots