Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP-FPM] Migrate to GA #7648

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

Migrates the integration from BETA to GA.

Related issues

@harnish-elastic harnish-elastic marked this pull request as ready for review September 4, 2023 13:41
@harnish-elastic harnish-elastic requested a review from a team as a code owner September 4, 2023 13:41
@elasticmachine
Copy link

elasticmachine commented Sep 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-05T09:01:50.678+0000

  • Duration: 16 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (16/16) 💚
Lines 95.763% (226/236) 👍 3.48
Conditionals 100.0% (0/0) 💚

@muthu-mps
Copy link
Contributor

@harnish-elastic - Please find my comments on the dashboard,

Size of the listen queue

  • Title change - Make it as Listen queue size
  • Mention size in units

Queued Connections

  • Both queued connections over time and Connections in listen queue has the internal title as Queued Connections.
  • Do we really need listen-queue queued connections in a separate visualisation. Can we club this together ? or else change the internal title.
Screenshot 2023-09-16 at 11 29 08 AM

@harnish-elastic
Copy link
Contributor Author

@harnish-elastic - Please find my comments on the dashboard,

Queued Connections

  • Both queued connections over time and Connections in listen queue has the internal title as Queued Connections.
  • Do we really need listen-queue queued connections in a separate visualisation. Can we club this together ? or else change the internal title.
Screenshot 2023-09-16 at 11 29 08 AM

@muthu-mps Thanks for your feedback. For the Connections in listen queue we can change the internal title and make it from Queued connections to Connections. Let me know if it looks good to you!

…into php-fpm-make-ga

Conflicts:
	packages/php_fpm/changelog.yml
	packages/php_fpm/manifest.yml
@harnish-elastic
Copy link
Contributor Author

harnish-elastic commented Sep 21, 2023

Size of the listen queue

  • Title change - Make it as Listen queue size

@muthu-mps It is updated, thanks!

  • Mention size in units

For the listen queue size the field indicates the size of the max connections in the listen queue. So for that field, the unit doesn't exist.

@muthu-mps
Copy link
Contributor

For the listen queue size the field indicates the size of the max connections in the listen queue. So for that field, the unit doesn't exist.

Just searched for the field in the PHP FPM connection pool metrics and the matching field is max listen queue size. We need to rename the title to Maximum Allowed Listen Queue Size. In this case the unit is not necessary.

@harnish-elastic
Copy link
Contributor Author

For the listen queue size the field indicates the size of the max connections in the listen queue. So for that field, the unit doesn't exist.

Just searched for the field in the PHP FPM connection pool metrics and the matching field is max listen queue size. We need to rename the title to Maximum Allowed Listen Queue Size. In this case the unit is not necessary.

Updated, thanks!

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: left a few minor comments

@harnish-elastic harnish-elastic merged commit 3b4d0d9 into elastic:main Oct 9, 2023
4 checks passed
@elasticmachine
Copy link

Package php_fpm - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make PHP-FPM GA
5 participants