-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP-FPM] Migrate to GA #7648
[PHP-FPM] Migrate to GA #7648
Conversation
🌐 Coverage report
|
@harnish-elastic - Please find my comments on the dashboard, Size of the listen queue
Queued Connections
|
@muthu-mps Thanks for your feedback. For the |
…into php-fpm-make-ga Conflicts: packages/php_fpm/changelog.yml packages/php_fpm/manifest.yml
@muthu-mps It is updated, thanks!
For the |
Just searched for the field in the PHP FPM connection pool metrics and the matching field is max listen queue size. We need to rename the title to Maximum Allowed Listen Queue Size. In this case the unit is not necessary. |
Updated, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: left a few minor comments
packages/php_fpm/kibana/dashboard/php_fpm-6853a270-5a92-11ed-8d56-a14fd29a60cb.json
Outdated
Show resolved
Hide resolved
packages/php_fpm/kibana/dashboard/php_fpm-6853a270-5a92-11ed-8d56-a14fd29a60cb.json
Outdated
Show resolved
Hide resolved
Package php_fpm - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm |
What does this PR do?
Migrates the integration from BETA to GA.
Related issues