Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Added mappings for meta object #7813

Merged
merged 7 commits into from
Sep 26, 2023
Merged

[Synthetics] Added mappings for meta object #7813

merged 7 commits into from
Sep 26, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 14, 2023 •
edited

In preparation for elastic/synthetics#729

Added mappings for meta object, this way we will be able to add field/values pairs in meta object as part of the document via processor from kibana.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-14T09:23:33.999+0000

  • Duration: 15 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 33.333% (6/18) 👎 -58.889
Lines 100.0% (0/0) 💚 14.136
Conditionals 100.0% (0/0) 💚

@shahzad31 shahzad31 marked this pull request as ready for review September 14, 2023 10:13
@shahzad31 shahzad31 requested a review from a team as a code owner September 14, 2023 10:13
awahab07
awahab07 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzad31 shahzad31 merged commit 83fadf1 into main Sep 26, 2023
4 checks passed
@shahzad31 shahzad31 deleted the meta-mappings branch September 26, 2023 15:55
@elasticmachine
Copy link

Package synthetics - 1.0.8 containing this change is available at https://epr.elastic.co/search?package=synthetics

@shahzad31 shahzad31 mentioned this pull request Sep 28, 2023
Merged
emilioalvap added a commit to emilioalvap/integrations that referenced this pull request Oct 2, 2023
@emilioalvap
Revert "[Synthetics] Added mappings for meta object (elastic#7813)"
ee05a5d 
This reverts commit 83fadf1.
emilioalvap added a commit to emilioalvap/integrations that referenced this pull request Oct 4, 2023
@emilioalvap
Revert "Revert "[Synthetics] Added mappings for meta object (elastic#…
26dd4be 
…7813)""

This reverts commit ee05a5d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shahzad31 @elasticmachine @awahab07