Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Fixes mappings regression #8005

Merged
merged 7 commits into from
Sep 28, 2023
Merged

[Synthetics] Fixes mappings regression #8005

merged 7 commits into from
Sep 28, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 28, 2023

Fixes mappings regression introduced by #7813

monitor fields properties got inside meta mistakenly.

@shahzad31 shahzad31 changed the title Fixes mappings regression introduced by https://github.com/elastic/integrations/pull/7813 [Synthetics] Fixes mappings regression Sep 28, 2023
@shahzad31 shahzad31 marked this pull request as ready for review September 28, 2023 07:44
@shahzad31 shahzad31 requested a review from a team as a code owner September 28, 2023 07:44
@elasticmachine
Copy link

elasticmachine commented Sep 28, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-28T13:24:11.833+0000

  • Duration: 14 min 13 sec

Steps errors 3

Expand to view the steps failures

Boot up the Elastic stack
  • Took 1 min 54 sec . View more details here
  • Description: ../../build/elastic-package stack up -d -v --version 8.11.0-SNAPSHOT
Google Storage Download
  • Took 0 min 0 sec . View more details here
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@shahzad31
Copy link
Contributor Author

/test

Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31
Copy link
Contributor Author

need to be forced merged because elastic-package new version is needed to pass some integeration tests failing here https://fleet-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-8005/8/pipeline

need a new version of pckage since synthetics kibana PR is blocked and needs a new synthetics version since that will make sure e2e tests starts passing in kibana

@jlind23 jlind23 merged commit 33f580f into main Sep 28, 2023
3 of 4 checks passed
@shahzad31 shahzad31 deleted the fix-mappings branch September 28, 2023 14:48
@elasticmachine
Copy link

Package synthetics - 1.0.9 containing this change is available at https://epr.elastic.co/search?package=synthetics

emilioalvap added a commit to emilioalvap/integrations that referenced this pull request Oct 2, 2023
emilioalvap added a commit to emilioalvap/integrations that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants