Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][K8] Migrate Deployments dashboard visualizations to lens #8265

Merged
merged 4 commits into from
Oct 31, 2023
Merged

[O11y][K8] Migrate Deployments dashboard visualizations to lens #8265

merged 4 commits into from
Oct 31, 2023

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Oct 23, 2023 •
edited
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate K8s Deployments visualizations to the lens in the current Kibana version 8.10.1 itself.

  • Statistics for K8s Deployments Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Metrics Kubernetes] Deployments 1 4 5 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.1 itself.

Related issues

Before Migration:
image

After Migration:
image

@kush-elastic kush-elastic marked this pull request as ready for review October 23, 2023 06:32
@kush-elastic kush-elastic requested review from a team as code owners October 23, 2023 06:32
@kush-elastic kush-elastic mentioned this pull request Oct 23, 2023
Closed
9 tasks
@elasticmachine
Copy link

elasticmachine commented Oct 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T15:34:50.262+0000

  • Duration: 53 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 94
Skipped 0
Total 94

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 96.25% (77/80) ❕
Lines 100.0% (22/22) 💚
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic self-assigned this Oct 23, 2023
@kush-elastic kush-elastic added enhancement New feature or request Integration:kubernetes Kubernetes dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Oct 23, 2023
drewdaemon
drewdaemon reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Could we decrease the height of the metric row by about half? That way the numbers will be much closer to the labels. Here is an example from System integration

host-overview-light

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 26, 2023
Closed
@kush-elastic
Copy link
Collaborator Author

kush-elastic commented Oct 27, 2023 •
edited
Loading

@drewdaemon, according to your comment Rajvi has raised a separate issue for tracking the changes related to size of metric visualizations. As already 3 dashboard PRs are merged for Kubernetes, they also require this change.
Link to new issue: #8308

rajvi-patel-22
rajvi-patel-22 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic
Copy link
Collaborator Author

@drewdaemon , can you help me review this PR?
I will need to merge this first to proceed with resizing issue.

@kush-elastic
Merge branch 'main' of https://github.com/kush-elastic/integrations i…
863906e 
…nto 7774-deployments-k8s-dashboard-lens-migration
drewdaemon
drewdaemon approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kush-elastic kush-elastic merged commit 9c1dac6 into elastic:main Oct 31, 2023
4 checks passed
@elasticmachine
Copy link

Package kubernetes - 1.51.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@gizas gizas gizas approved these changes

@rajvi-patel-22 rajvi-patel-22 rajvi-patel-22 approved these changes

@gsantoro gsantoro Awaiting requested review from gsantoro gsantoro is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@kush-elastic kush-elastic

Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:kubernetes Kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kush-elastic @elasticmachine @drewdaemon @gizas @rajvi-patel-22