-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][K8s] Update size of the metric visualizations #8337
[O11y][K8s] Update size of the metric visualizations #8337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
🌐 Coverage report
|
Actually, you could also probably hide those panel titles. The metric visualization labels itself. (not a blocker, though!) |
…nto 8308-observability-kuberneteslens-resize-visualizations
…nto 8308-observability-kuberneteslens-resize-visualizations
@drewdaemon, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
To me, this is still preferable to having the metric number so far from the label. Readability > style. But, cc @gvnmagni for a second opinion. |
Agreed! If we are concerned about the metric panel size, it could also be placed next to the markdown panel (which would need to get smaller, just a little) |
Nice idea, let me try it. |
@drewdaemon @gvnmagni , |
@drewdaemon @gvnmagni, any suggestions? |
Apologies for not answering earlier @kush-elastic, I just got back from PTO. I feel like ti works! You saved a lot of space and it seems very elegant to me 👍 |
No worries, i will update the PR with updated dashboard and proceed with merging this. |
@drewdaemon @gvnmagni, |
Package kubernetes - 1.53.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
What does this PR do?
K8s
Integration Dashboard's visualizations in the current Kibana version8.10.2
itself.Checklist
changelog.yml
file.Related issues
Screenshots
Before (Sample for one dashboard):-
![image](https://private-user-images.githubusercontent.com/89848966/279102011-d4ba5d9e-40c0-4324-bb6f-81830c759234.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwOTk5MDUsIm5iZiI6MTcyNjA5OTYwNSwicGF0aCI6Ii84OTg0ODk2Ni8yNzkxMDIwMTEtZDRiYTVkOWUtNDBjMC00MzI0LWJiNmYtODE4MzBjNzU5MjM0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDAwMDY0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBkOTUyNWFiZGEyMGEyNDBlMWU0MjU4YWUzYTg2NjI4MzMyNGU4Mjg0YTRmMjMyYTIzMzBlMTg5MTIyMDg2MTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.la442b8_xgjPlH9kAK-P7yiMKAQSbhhgTG9poz7gC9s)
After
![image](https://private-user-images.githubusercontent.com/89848966/279102108-c46d063c-35bb-4af2-9d88-56615c0967a1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwOTk5MDUsIm5iZiI6MTcyNjA5OTYwNSwicGF0aCI6Ii84OTg0ODk2Ni8yNzkxMDIxMDgtYzQ2ZDA2M2MtMzViYi00YWYyLTlkODgtNTY2MTVjMDk2N2ExLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDAwMDY0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM4OGQ0ODU0NWRhNzBkMjM0ODQ2Y2YxYmVkODhhYzZiMWUxMWFmOTQ1YjgwNjM4YmIyNDg2NmZlMDBkNzYxMzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YUhNsdePZtCBjhoUpVUN9Fd_sPK46oRUSaZFTSDXvlw)