Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][K8s] Update size of the metric visualizations #8337

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Oct 30, 2023

What does this PR do?

  • Resize K8s Integration Dashboard's visualizations in the current Kibana version 8.10.2 itself.
  Count of visualizations resized
[Metrics Kubernetes] Cronjobs 1
[Metrics Kubernetes] StatefulSets 5
[Metrics Kubernetes] DaemonSets 4
[Metrics Kubernetes] Deployments 4
[Metrics Kubernetes] Jobs 3

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before (Sample for one dashboard):-
image

After
image

@kush-elastic kush-elastic changed the title k8s resize visualizations [O11y][K8s] Update size of the metric visualizations Oct 30, 2023
@kush-elastic kush-elastic marked this pull request as ready for review October 30, 2023 15:06
@kush-elastic kush-elastic requested review from a team as code owners October 30, 2023 15:06
@kush-elastic kush-elastic self-assigned this Oct 30, 2023
@kush-elastic kush-elastic added enhancement New feature or request Integration:kubernetes Kubernetes dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Oct 30, 2023
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elasticmachine
Copy link

elasticmachine commented Oct 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-07T05:54:24.303+0000

  • Duration: 60 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 97
Skipped 0
Total 97

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 96.386% (80/83) 👎 -1.553
Lines 100.0% (22/22) 💚 17.963
Conditionals 100.0% (0/0) 💚

@drewdaemon
Copy link
Contributor

drewdaemon commented Oct 30, 2023

Actually, you could also probably hide those panel titles. The metric visualization labels itself. (not a blocker, though!)

@kush-elastic
Copy link
Collaborator Author

Actually, you could also probably hide those panel titles. The metric visualization labels itself. (not a blocker, though!)

Thanks for the review,
It's done.
Check out the below sample:

image

…nto 8308-observability-kuberneteslens-resize-visualizations
@kush-elastic
Copy link
Collaborator Author

@drewdaemon,
What do you think about the below dashboard?
If we resize the lower left panel(which is also metric type) of the dashboard it might look a bit weird based on the next panel to it.
image

Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drewdaemon
Copy link
Contributor

To me, this is still preferable to having the metric number so far from the label. Readability > style.

But, cc @gvnmagni for a second opinion.

@gvnmagni
Copy link

gvnmagni commented Nov 1, 2023

Agreed! If we are concerned about the metric panel size, it could also be placed next to the markdown panel (which would need to get smaller, just a little)

@kush-elastic
Copy link
Collaborator Author

Agreed! If we are concerned about the metric panel size, it could also be placed next to the markdown panel (which would need to get smaller, just a little)

Nice idea, let me try it.

@kush-elastic
Copy link
Collaborator Author

kush-elastic commented Nov 2, 2023

@drewdaemon @gvnmagni ,
What do you think about this?
image

@kush-elastic
Copy link
Collaborator Author

@drewdaemon @gvnmagni , What do you think about this? image

@drewdaemon @gvnmagni, any suggestions?

@gvnmagni
Copy link

gvnmagni commented Nov 6, 2023

Apologies for not answering earlier @kush-elastic, I just got back from PTO. I feel like ti works! You saved a lot of space and it seems very elegant to me 👍

@kush-elastic
Copy link
Collaborator Author

Apologies for not answering earlier @kush-elastic, I just got back from PTO. I feel like ti works! You saved a lot of space and it seems very elegant to me 👍

No worries, i will update the PR with updated dashboard and proceed with merging this.
Thanks

@kush-elastic
Copy link
Collaborator Author

@drewdaemon @gvnmagni,
I am merging this as discussed before.

@kush-elastic kush-elastic merged commit 53ad8d7 into elastic:main Nov 7, 2023
4 checks passed
@elasticmachine
Copy link

Package kubernetes - 1.53.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:kubernetes Kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][K8s] Update size of the metric visualizations
7 participants