Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etcd] Fix incorrect field mapping in leader dataset #8417

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

agithomas
Copy link
Contributor

  • Bug

Proposed commit message

Fix the field mappings under leader datastream

Please explain:

The field mapping of the leader datastream is incorrect.
This change fixes the incorrect field mapping.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

How to test this PR locally

  • Verification of field mappings after the change

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Nov 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-07T10:02:29.341+0000

  • Duration: 16 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 64.286% (9/14) 👎 -35.714
Lines 100.0% (0/0) 💚 1.279
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor Author

New mapping details are below

  "etcd": {
        "properties": {
          "api_version": {
            "type": "keyword",
            "ignore_above": 1024
          },
          "leader": {
            "properties": {
              "follower": {
                "properties": {
                  "failed_operations": {
                    "type": "long"
                  },
                  "id": {
                    "type": "keyword",
                    "ignore_above": 1024
                  },
                  "latency": {
                    "properties": {
                      "ms": {
                        "type": "scaled_float",
                        "scaling_factor": 1000
                      }
                    }
                  },
                  "leader": {
                    "type": "keyword",
                    "ignore_above": 1024
                  },
                  "success_operations": {
                    "type": "long"
                  }
                }
              }
            }
          }
        }
      },

@agithomas agithomas marked this pull request as ready for review November 7, 2023 14:35
@agithomas agithomas requested a review from a team as a code owner November 7, 2023 14:35
@agithomas agithomas requested a review from gpop63 November 8, 2023 08:09
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 147cc49 into elastic:main Nov 9, 2023
4 checks passed
@elasticmachine
Copy link

Package etcd - 0.6.1 containing this change is available at https://epr.elastic.co/search?package=etcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[etcd] Incorrect leader field definitions
5 participants