elastic/obs-infraobs-integrations: Address skipped validation SVR00004

[shmsr]

Tip: How to use the inliner script? Follow this. Also read the following:

Set this to your environment (e.g., prepend when executing the inliner script) NODE_TLS_REJECT_UNAUTHORIZED='0' to bypass certificate verification for TLS connections and HTTPS requests as elastic-package deploys the stack with TLS on by default.

Proposed commit message

Used https://github.com/elastic/visualizations_integrations_tools/blob/master/inline.js to inline "by reference" viz.

• apache_spark
• azure_functions
• hadoop
• iis
• oracle_weblogic
• spring_boot
• traefik
• websphere_application_server

Couldn't migrate other packages 11 packages out of 19 packages with SVR00004 as inliner script does not support inlining saved searches because the script was developed before users could have by-value (inline) saved searches in Kibana dashboards. So those packages have references to "search" and hence SVR00004 couldn't be addressed.

Thanks to Drew for creating this related issue to update the inliner script: elastic/visualizations_integrations_tools#2

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Here is a list of packages that have SVR00004 with the kibana.version:

activemq == ^8.8.0 
apache_spark == ^8.8.0
apache_tomcat == ^8.8.0
azure_functions == ^8.8.1
cassandra == ^8.8.0
hadoop == ^8.10.2
iis == ^8.8.0
kafka == ^8.8.0
microsoft_sqlserver == ^8.10.2
mongodb == ^8.8.0
mysql == ^8.8.2
nginx == ^8.8.0
oracle_weblogic == ^8.8.0
postgresql == ^8.8.0
redis == ^8.10.2
spring_boot == ^8.9.0
system == ^8.10.2
traefik == ^8.9.0
websphere_application_server == ^8.3.0

• Note that, using the inliner script will make the dashboards incompatible with earlier versions of the stack. For example, if the inliner script is used with 8.8 stack then the dashboard generated will be compatible with stack 8.8 and above.
• So, all packages with SVR00004 can be migrated with 8.8.0 stack as the kibana.version is either 8.8.0 or above except websphere_application_server (8.3.0).

• For all packages, except websphere_application_server; stack used for inliner script: v8.8.0
• For websphere_application_server, stack used for inliner script: v8.3.0

How to test this PR locally

Review should include loading the dashboard into an instance with data to make sure everything is displayed properly.

Related issues

• elastic/obs-infraobs-integrations: Skipped validations during migration of packages to format_version: 3.0.0 (package-spec v3) #8452
• migrate obs-infraobs-integrations owned packages to format_version: 3.0.0  #8028

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-11-07T17:52:09.192+0000

• Duration: 27 min 35 sec

Test stats 🧪

Test	Results
Failed	0
Passed	160
Skipped	0
Total	160

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (19/19)	💚
Files	100.0% (26/26)	💚
Classes	100.0% (26/26)	💚
Methods	95.436% (230/241)	👎 -4.564
Lines	98.256% (2197/2236)	👎 -0.465
Conditionals	100.0% (0/0)	💚

[shmsr]

Please read the full PR description before reviewing.

[lalit-satapathy]

CC: @harnish-elastic @aliabbas-elastic to review the dashboard changes as part of the pass by value is correctly being added.

[aliabbas-elastic]

LGTM for the changes. Please refer here for testing details

[mrodm]

Hi @shmsr, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

[lalit-satapathy]

@shmsr,

What is pending on this as the validation is complete?

[shmsr]

@shmsr,

What is pending on this as the validation is complete?

I have to resolve the merge conflicts. I'll do it ASAP.

[shmsr]

@harnish-elastic @aliabbas-elastic I have resolved the merge conflicts. I had to inline viz in springboot from the checkout of main brain as dashboard changes had been made in the last couple of months. Otherwise, for other packages only manifest and changelog yaml's are touched.

So it'd be great if could take a look at springboot again.

[botelastic]

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

[shmsr]

Fixed merge conflicts.

[elasticmachine]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: e3a4b9e

cc @shmsr

[elastic-sonarqube]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[shmsr]

As latest changes in oracle_weblogic includes saved searches; inlining them could only be done for 8.10 or above stack. So leaving out oracle_weblogic.

cc: @harnish-elastic

[elasticmachine]

Package apache_spark - 1.0.2 containing this change is available at https://epr.elastic.co/search?package=apache_spark

[elasticmachine]

Package azure_functions - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=azure_functions

[elasticmachine]

Package hadoop - 1.5.2 containing this change is available at https://epr.elastic.co/search?package=hadoop

[elasticmachine]

Package iis - 1.17.4 containing this change is available at https://epr.elastic.co/search?package=iis

[elasticmachine]

Package spring_boot - 1.2.2 containing this change is available at https://epr.elastic.co/search?package=spring_boot

[elasticmachine]

Package traefik - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=traefik

[elasticmachine]

Package websphere_application_server - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server