Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y] Address skipped validation SVR00004 #9011

Closed

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Jan 30, 2024

Proposed commit message

  • Here is a list of packages (8 packages) that have SVR00004 with the current kibana.version:
activemq == ^8.8.0
apache_tomcat == ^8.8.0
cassandra == ^8.8.0
kafka == ^8.8.0
mongodb == ^8.8.0
mysql == ^8.8.2
nginx == ^8.8.0
postgresql == ^8.8.0
  • Fixed SVR00004 validation and bump the Kibana version to 8.10.1 for those packages which contains kibana < 8.10

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Verified all dashboards are working as expected after fixing SVR00004

Related issues

@harnish-elastic harnish-elastic marked this pull request as ready for review January 30, 2024 11:48
@harnish-elastic harnish-elastic requested review from a team as code owners January 30, 2024 11:48
@elasticmachine
Copy link

elasticmachine commented Jan 30, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@shmsr
Copy link
Member

shmsr commented Jan 31, 2024

Let me resolve the conflict in #8423 to enable merging batch 1 before this one, even though both are independent. Also, approval is required from other teams for this PR.

But I see the CI failed because of some issue in mongodb. PTAL?

@shmsr shmsr self-requested a review January 31, 2024 11:41
@harnish-elastic
Copy link
Contributor Author

harnish-elastic commented Jan 31, 2024

Let me resolve the conflict in #8423 to enable merging batch 1 before this one, even though both are independent. Also, approval is required from other teams for this PR.

Sure

But I see the CI failed because of some issue in mongodb. PTAL?

For the mongodb, the system tests are failing and showing this error!

mongodb/collstats collstats:
[0] found error.message in event: ['top' command failed: server selection error: server selection timeout, current topology: { Type: Unknown, Servers: [{ Addr: elastic-package-service_mongodb_1:27017, Type: RSGhost, Average RTT: 1714128 }, ] }]
mongodb/dbstats dbstats:
[0] found error.message in event: [could not retrieve database names from Mongo instance: server selection error: server selection timeout, current topology: { Type: Unknown, Servers: [{ Addr: elastic-package-service_mongodb_1:27017, Type: RSGhost, Average RTT: 465420 }, ] }]
mongodb/metrics metrics:
[0] found error.message in event: [failed to retrieve data from 'serverStatus' command: server selection error: server selection timeout, current topology: { Type: Unknown, Servers: [{ Addr: elastic-package-service_mongodb_1:27017, Type: RSGhost, Average RTT: 412015 }, ] }]
mongodb/status status:
[0] found error.message in event: [failed to retrieve 'serverStatus': server selection error: server selection timeout, current topology: { Type: Unknown, Servers: [{ Addr: elastic-package-service_mongodb_1:27017, Type: RSGhost, Average RTT: 355797 }, ] }]

image

@harnish-elastic harnish-elastic marked this pull request as draft February 5, 2024 05:30
@elasticmachine
Copy link

elasticmachine commented Feb 5, 2024

💔 Build Failed

Failed CI Steps

History

cc @harnish-elastic

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@botelastic
Copy link

botelastic bot commented Mar 6, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 6, 2024
@botelastic
Copy link

botelastic bot commented Apr 5, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Apr 5, 2024
@ishleenk17
Copy link
Contributor

@shmsr : Still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants