New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] [DNS logs] Don't parse rdata
when it is empty
#8447
Merged
zmoog
merged 6 commits into
elastic:main
from
zmoog:zmoog/fix-empty-rdata-in-gcp-dns-logs
Nov 21, 2023
Merged
[GCP] [DNS logs] Don't parse rdata
when it is empty
#8447
zmoog
merged 6 commits into
elastic:main
from
zmoog:zmoog/fix-empty-rdata-in-gcp-dns-logs
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoog
added
Team:Cloud-Monitoring
Label for the Cloud Monitoring team
bug
Something isn't working
labels
Nov 9, 2023
🌐 Coverage report
|
efd6
reviewed
Nov 13, 2023
packages/gcp/data_stream/dns/_dev/test/pipeline/test-dns-empty-rdata.log
Outdated
Show resolved
Hide resolved
packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
zmoog
force-pushed
the
zmoog/fix-empty-rdata-in-gcp-dns-logs
branch
from
November 14, 2023 12:49
9bf8fea
to
7a4be8e
Compare
kaiyan-sheng
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Hey @efd6, do you think we should make other changes to this PR, or we're good? |
efd6
approved these changes
Nov 20, 2023
A user reported pipeline errors occurring when the `rdata` is set to an empty string. I am looking for the actual sample document from GCP, but in the meantime, I'm trying to reproduce the issue by modifying another test document.
…-rdata.log Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
…ault.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
zmoog
force-pushed
the
zmoog/fix-empty-rdata-in-gcp-dns-logs
branch
from
November 21, 2023 04:56
7a4be8e
to
09504e2
Compare
Package gcp - 2.31.2 containing this change is available at https://epr.elastic.co/search?package=gcp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Integration:GCP
Team:Cloud-Monitoring
Label for the Cloud Monitoring team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Extends the pipeline
script
processor check to processrdata
field only if it's not null and not an empty string.A user reported pipeline errors occurring when the
rdata
is an empty string.Checklist
I have verified that all data streams collect metrics or logs.changelog.yml
file.I have verified that Kibana version constraints are current according to guidelines.How to test this PR locally
cd packages/gcp