Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] [DNS logs] Don't parse rdata when it is empty #8447

Merged
merged 6 commits into from
Nov 21, 2023
Merged

[GCP] [DNS logs] Don't parse rdata when it is empty #8447

merged 6 commits into from
Nov 21, 2023

Commits on Nov 21, 2023

  1. Don't parse rdata when it is empty 

    A user reported pipeline errors occurring when the `rdata` is set to
an empty string.

I am looking for the actual sample document from GCP, but in the
meantime, I'm trying to reproduce the issue by modifying another test
document.
    @zmoog
    zmoog committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    cd7e6b9 View commit details
    Browse the repository at this point in the history

  2. Replace the test document with an actual one

    @zmoog
    zmoog committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f3206b4 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @zmoog
    zmoog committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e017c34 View commit details
    Browse the repository at this point in the history

  4. Update packages/gcp/data_stream/dns/_dev/test/pipeline/test-dns-empty… 

    …-rdata.log

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
    @zmoog @efd6
    zmoog and efd6 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2d3c353 View commit details
    Browse the repository at this point in the history

  5. Update packages/gcp/data_stream/dns/elasticsearch/ingest_pipeline/def… 

    …ault.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
    @zmoog @efd6
    zmoog and efd6 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bae6550 View commit details
    Browse the repository at this point in the history

  6. Update expected result

    @zmoog
    zmoog committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    09504e2 View commit details
    Browse the repository at this point in the history