Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11Y] [AWS Billing] Convert "Total Estimated Charges" visualization to new metric #8509

Merged
merged 10 commits into from Dec 19, 2023
Merged

[O11Y] [AWS Billing] Convert "Total Estimated Charges" visualization to new metric #8509

merged 10 commits into from Dec 19, 2023

Conversation

niraj-elastic
Copy link
Contributor

@niraj-elastic niraj-elastic commented Nov 15, 2023 •
edited

What does this PR do?

If we use the new metric chart and if the value is 5004 then the new metric visualization will show us 5k. It won't show us the actual value that is 5004. Also there isn't any option available to change this behavior. Hence legacy metric was used for Total Estimated Charges panel while migrating to lens.

Kibana 8.10.2 supports custom formatting for new metric visualization. Hence Converting Total Estimated Charges panel to new metric visualization is needed.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels is populated with data.
  • I have updated screenshots of the dashboard.
  • I have verified that the panel aggregations are the same as before.

Related issues

Screenshots

Before
metricbeat-aws-billing-overview (1)

After
metricbeat-aws-billing-overview

@niraj-elastic niraj-elastic requested review from a team as code owners November 15, 2023 06:35
@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Nov 15, 2023 •
edited

💚 CLA has been signed

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-18T12:52:03.649+0000

  • Duration: 84 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 223
Skipped 3
Total 226

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@harnish-elastic
Copy link
Contributor

/test

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍
Classes 94.444% (17/18) 👍
Methods 89.701% (270/301) 👍 12.298
Lines 86.083% (7571/8795) 👍
Conditionals 100.0% (0/0) 💚

@niraj-elastic
Merge branch 'main' of github.com:niraj-elastic/integrations into aws…
e2ef1c2 
…-convert-billing-visualization-to-new-metric

Conflicts:
	packages/aws/changelog.yml
@drewdaemon
Copy link
Contributor

@niraj-elastic thanks for doing this! The new metric is quite different from the legacy in that the label and the text can be too far apart in large panels. What do you think about updating the layout of the dashboard to look like this?

Screenshot 2023-11-16 at 7 37 43 AM

harnish-elastic
harnish-elastic approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niraj-elastic
Copy link
Contributor Author

@niraj-elastic thanks for doing this! The new metric is quite different from the legacy in that the label and the text can be too far apart in large panels. What do you think about updating the layout of the dashboard to look like this?

Screenshot 2023-11-16 at 7 37 43 AM

@drewdaemon Updated, thanks!

drewdaemon
drewdaemon approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zmoog
zmoog approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Convert Total Estimated Charges panel to new metric visualization.

It would be great to have an 'executive summary' style recap of the changes in the PR description, for example:

  • How it was before and how it is now
  • Why we are making this change

@niraj-elastic
Copy link
Contributor Author

nit:

Convert Total Estimated Charges panel to new metric visualization.

It would be great to have an 'executive summary' style recap of the changes in the PR description, for example:

  • How it was before and how it is now
  • Why we are making this change

@zmoog Made the changes, thanks!

@aliabbas-elastic
Copy link
Contributor

/test

@niraj-elastic
Merge branch 'main' of github.com:niraj-elastic/integrations into aws…
2a10394 
…-convert-billing-visualization-to-new-metric

Conflicts:
	packages/aws/changelog.yml
	packages/aws/manifest.yml
@niraj-elastic
Merge branch 'aws-convert-billing-visualization-to-new-metric' of git…
3f6fa0a 
…hub.com:niraj-elastic/integrations into aws-convert-billing-visualization-to-new-metric
@niraj-elastic
update kibana version
8f103ba
@aliabbas-elastic
Copy link
Contributor

/test

2 similar comments
@aliabbas-elastic
Copy link
Contributor

/test

@aliabbas-elastic
Copy link
Contributor

/test

@niraj-elastic
Merge branch 'main' of github.com:niraj-elastic/integrations into aws…
0a51288 
…-convert-billing-visualization-to-new-metric

Conflicts:
	packages/aws/changelog.yml
	packages/aws/manifest.yml
@niraj-elastic niraj-elastic force-pushed the aws-convert-billing-visualization-to-new-metric branch from 941c1aa to 0a51288 Compare December 18, 2023 12:51
@aliabbas-elastic aliabbas-elastic merged commit 53ee985 into elastic:main Dec 19, 2023
3 checks passed
@elasticmachine
Copy link

Package aws - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=aws

v1v added a commit that referenced this pull request Dec 21, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into v1v-patch-1
3e599b5 
* upstream/main: (117 commits)
  [TI MISP] Add IOC expiration support (#8639)
  Add CSPM Rules 6.2, 6.3 and 6.4 (#8778)
  [Infoblox NIOS] Update timestamp parsing logic (#8767)
  [Rapid7 InsightVM] Split vulnerability categories into array (#8768)
  [Exchange Online Message Trace] Add Additional Look-back Time & Fix Cursor Value (#8717)
  [Buildkite] Update bucket settings (#8765)
  Remove Jenkins .ci folder (#8766)
  First part of removal of Jenkins jobs (#8763)
  misp: parse URIs for URI type threats (#8760)
  [amazon_security_lake] Added support for all the OCSF Classes (#8579)
  [Buildkite] Update settings for integrations pipeline (#8758)
  [TI ThreatQ] Add IOC expiration support (#8691)
  [ti_opencti] Support OpenCTI 5.12 by removing filters parameter (#8744)
  [Cribl] Updating setup guidance for Cribl field (#8746)
  crowdstrike: add userinfo enrichment support and map fields to ECS (#8742)
  [etcd] Enable TSDB for metrics datastream (#8649)
  Bump golang.org/x/crypto from 0.16.0 to 0.17.0 (#8749)
  auditd: relax field_split pattern and handle AVC header (#8748)
  Update cloud packages codeowner (#8672)
  [O11Y] [AWS Billing] Convert "Total Estimated Charges" visualization to new metric (#8509)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

@harnish-elastic harnish-elastic harnish-elastic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@niraj-elastic @elasticmachine @harnish-elastic @drewdaemon @aliabbas-elastic @zmoog