Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[etcd] Enable TSDB for metrics datastream #8649

Merged
merged 4 commits into from Dec 19, 2023
Merged

[etcd] Enable TSDB for metrics datastream #8649

merged 4 commits into from Dec 19, 2023

Conversation

agithomas
Copy link
Contributor

  • Enhancement

Proposed commit message

  • Enable time series data streams for the metrics datasets.
  • This improves storage usage and query performance.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Package testing
  • Disablement & Rollover testing

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Related issues

Screenshots

#8438 (comment)

TSDB Testkit output

#8438 (comment)

@elasticmachine
Copy link

elasticmachine commented Dec 5, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-15T10:52:39.785+0000

  • Duration: 17 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@agithomas agithomas marked this pull request as ready for review December 5, 2023 06:57
@agithomas agithomas requested a review from a team as a code owner December 5, 2023 06:57
@elasticmachine
Copy link

elasticmachine commented Dec 5, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 60.0% (9/15) 👎 -40.0
Lines 100.0% (0/0) 💚 6.71
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor Author

/test

2 similar comments
@agithomas
Copy link
Contributor Author

/test

@gpop63
Copy link
Contributor

gpop63 commented Dec 6, 2023

/test

@gpop63
Copy link
Contributor

gpop63 commented Dec 7, 2023 •
edited

@agithomas I created a PR (#8663) to test if CI passes with a single variant like you suggested, and it does after I removed these 2 variants.

diff --git a/packages/etcd/_dev/deploy/variants.yml b/packages/etcd/_dev/deploy/variants.yml
index d4bb730c31..f9af2ac973 100644
--- a/packages/etcd/_dev/deploy/variants.yml
+++ b/packages/etcd/_dev/deploy/variants.yml
@@ -1,8 +1,4 @@
 variants:
   etcd_3_5_1:
     SERVICE_VERSION: 3.5.1
-  etcd_3_3_8:
-    SERVICE_VERSION: 3.3.8
-  etcd_3:
-    SERVICE_VERSION: 3
 default: etcd_3_5_1

@agithomas
Copy link
Contributor Author

Yes, thanks for testing it.

While this is an issue which must be reported to the elastic-package team, I do not think, there exists a merit in testing variants having minor number differences (all versions are 3.x.y) . Please correct me if I am wrong.

@agithomas
Copy link
Contributor Author

@ritalwar , can you please review the PR?

@agithomas agithomas mentioned this pull request Dec 18, 2023
Open
@agithomas
Copy link
Contributor Author

I have created an issue to assess the impact of multiple variants in system testing with TSDB enablement.

Note: MySQL integration, having multiple variants did not have similar issues.

ritalwar
ritalwar approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 1b93283 into elastic:main Dec 19, 2023
4 checks passed
@elasticmachine
Copy link

Package etcd - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=etcd

@agithomas agithomas mentioned this pull request Dec 19, 2023
Closed
6 tasks
v1v added a commit that referenced this pull request Dec 21, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into v1v-patch-1
3e599b5 
* upstream/main: (117 commits)
  [TI MISP] Add IOC expiration support (#8639)
  Add CSPM Rules 6.2, 6.3 and 6.4 (#8778)
  [Infoblox NIOS] Update timestamp parsing logic (#8767)
  [Rapid7 InsightVM] Split vulnerability categories into array (#8768)
  [Exchange Online Message Trace] Add Additional Look-back Time & Fix Cursor Value (#8717)
  [Buildkite] Update bucket settings (#8765)
  Remove Jenkins .ci folder (#8766)
  First part of removal of Jenkins jobs (#8763)
  misp: parse URIs for URI type threats (#8760)
  [amazon_security_lake] Added support for all the OCSF Classes (#8579)
  [Buildkite] Update settings for integrations pipeline (#8758)
  [TI ThreatQ] Add IOC expiration support (#8691)
  [ti_opencti] Support OpenCTI 5.12 by removing filters parameter (#8744)
  [Cribl] Updating setup guidance for Cribl field (#8746)
  crowdstrike: add userinfo enrichment support and map fields to ECS (#8742)
  [etcd] Enable TSDB for metrics datastream (#8649)
  Bump golang.org/x/crypto from 0.16.0 to 0.17.0 (#8749)
  auditd: relax field_split pattern and handle AVC header (#8748)
  Update cloud packages codeowner (#8672)
  [O11Y] [AWS Billing] Convert "Total Estimated Charges" visualization to new metric (#8509)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpop63 gpop63 gpop63 approved these changes

@ritalwar ritalwar ritalwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@agithomas @elasticmachine @gpop63 @ritalwar