Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SEI] Promote packages to GA #8833

Merged
merged 7 commits into from Jan 23, 2024
Merged

[SEI] Promote packages to GA #8833

merged 7 commits into from Jan 23, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 5, 2024 •
edited

Proposed commit message

  • Promote many packages to GA
  • Upgraded package-spec to 3.0.0 where necessary

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package test

Related issues

@taylor-swanson
[SEI] Promote packages to GA
888986f 
- Promote many pacakges to GA
- Upgraded package-spec to 3.0.0 where necessary
@taylor-swanson taylor-swanson self-assigned this Jan 5, 2024
taylor-swanson
taylor-swanson commented Jan 5, 2024
View reviewed changes
packages/aws_logs/changelog.yml Outdated
Comment on lines 1 to 5
- version: "1.0.0"
changes:
- description: Release package as GA.
type: enhancement
link: https://github.com/elastic/integrations/pull/8833
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/obs-ds-hosted-services, aws_logs was included in the list of packages to promote to GA (see #8389). If there any objections to this and the package is not ready for GA, I'll remove it from this list.

@elasticmachine
Copy link

elasticmachine commented Jan 5, 2024 •
edited

🚀 Benchmarks report

Package arista_ngfw 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1501.5 1272.26 -229.24 (-15.27%) 💔

Package prisma_cloud 👍(3) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
host_profile 1742.16 1449.28 -292.88 (-16.81%) 💔

Package qualys_vmdr 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
knowledge_base 1597.44 1239.16 -358.28 (-22.43%) 💔

Package wiz 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2564.1 1945.53 -618.57 (-24.12%) 💔

To see the full report comment with /test benchmark fullreport

@taylor-swanson
Copy link
Contributor Author

/test

@taylor-swanson taylor-swanson marked this pull request as ready for review January 9, 2024 14:30
@taylor-swanson taylor-swanson requested review from a team as code owners January 9, 2024 14:30
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson
Copy link
Contributor Author

As a side note, elastic-package performed a lot of formatting/whitespace changes on some of the files, so it may help to hide whitespace changes to make it quicker to review.

kcreddy
kcreddy approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@taylor-swanson
Copy link
Contributor Author

@elastic/obs-ds-hosted-services, would some one be able to review this? Specifically, the aws_logs package. It was included in the list of packages to promote to GA (see #8389). If there any objections to this and the package is not ready for GA, I'll remove it from this list.

(cc @zmoog, @aspacca in case the elastic/obs-ds-hosted-services handle isn't sending notifications)

@ebeahan ebeahan mentioned this pull request Jan 18, 2024
Closed
@taylor-swanson
Copy link
Contributor Author

/test

5 similar comments
@taylor-swanson
Copy link
Contributor Author

/test

@taylor-swanson
Copy link
Contributor Author

/test

@bhapas
Copy link
Contributor

bhapas commented Jan 22, 2024

/test

@taylor-swanson
Copy link
Contributor Author

/test

@taylor-swanson
Copy link
Contributor Author

/test

@jamiehynds
Copy link

@taylor-swanson sorry for late notice. Is it possible to keep SentinelOne Cloud Funnel in Tech Preview as @w0rk3r has some mapping adjustments to make to ensure our detection rules can leverage S1 Cloud Funnel data. Easier to make those mapping adjustments while in Tech Preview.

@taylor-swanson
Copy link
Contributor Author

@taylor-swanson sorry for late notice. Is it possible to keep SentinelOne Cloud Funnel in Tech Preview as @w0rk3r has some mapping adjustments to make to ensure our detection rules can leverage S1 Cloud Funnel data. Easier to make those mapping adjustments while in Tech Preview.

Absolutely, I'll remove it from the list now.

As a note, I don't think the numerous test failures I'm hitting are anything to do with the integrations, there's something weird going on with CI lately.

@taylor-swanson
Copy link
Contributor Author

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson taylor-swanson merged commit b983c10 into elastic:main Jan 23, 2024
3 checks passed
@taylor-swanson taylor-swanson deleted the sei-ga-pkgs branch January 23, 2024 20:49
@taylor-swanson taylor-swanson mentioned this pull request Jan 23, 2024
Closed
18 tasks
@elasticmachine
Copy link

Package amazon_security_lake - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=amazon_security_lake

@elasticmachine
Copy link

Package arista_ngfw - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=arista_ngfw

@elasticmachine
Copy link

Package cisco_nexus - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=cisco_nexus

@elasticmachine
Copy link

Package entityanalytics_entra_id - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_entra_id

@elasticmachine
Copy link

Package entityanalytics_okta - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_okta

@elasticmachine
Copy link

Package google_scc - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=google_scc

@elasticmachine
Copy link

Package imperva - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=imperva

@elasticmachine
Copy link

Package microsoft_defender_cloud - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_cloud

@elasticmachine
Copy link

Package prisma_cloud - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=prisma_cloud

@elasticmachine
Copy link

Package qualys_vmdr - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=qualys_vmdr

@elasticmachine
Copy link

Package symantec_edr_cloud - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=symantec_edr_cloud

@elasticmachine
Copy link

Package ti_maltiverse - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=ti_maltiverse

@elasticmachine
Copy link

Package ti_mandiant_advantage - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=ti_mandiant_advantage

@elasticmachine
Copy link

Package ti_opencti - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=ti_opencti

@elasticmachine
Copy link

Package trellix_edr_cloud - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=trellix_edr_cloud

@elasticmachine
Copy link

Package wiz - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=wiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Integrations] Moving integrations from Tech Preview to GA
6 participants
@taylor-swanson @elasticmachine @bhapas @jamiehynds @kcreddy @efd6