Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M365 Defender integration - fix on process.command_line #8872

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

daverick
Copy link
Contributor

@daverick daverick commented Jan 12, 2024

process.command_line was overwritten by process.parent.command_line due to a typo in the script parsing the parent.command line

Proposed commit message

fix process.command_line overwritten by process.parent.command_line

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@daverick daverick added bug Something isn't working, use only for issues Integration:m365_defender Microsoft M365 Defender labels Jan 12, 2024
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an entry into changelog.yml like this: https://github.com/elastic/integrations/blob/main/packages/m365_defender/changelog.yml#L12-L16. Since this is a bugfix, the version here would be 2.5.1

Can you also update manifest.yml here with version 2.5.1?

@daverick
Copy link
Contributor Author

@kcreddy done.
I have update the tests too. I don't have a way to really test these changes are corrects ;-(

@daverick daverick marked this pull request as ready for review January 12, 2024 13:19
@daverick daverick requested a review from a team as a code owner January 12, 2024 13:19
@kcreddy
Copy link
Contributor

kcreddy commented Jan 12, 2024

/test

@kcreddy
Copy link
Contributor

kcreddy commented Jan 12, 2024

I don't have a way to really test these changes are corrects ;-(

After the change to the painless script, your change is valid according to this block of code:

"process": {
"args": [
"smartscreen.exe",
"-Embedding"
],
"args_count": 2,
"command_line": "smartscreen.exe -Embedding",
"executable": "C:\\Windows\\System32\\smartscreen.exe",
"hash": {
"md5": "b9d697df9e883f0d99720b0430448cb1",
"sha1": "9dec87de894f5228033f87cf874441502bfa4f97",
"sha256": "8011a5f4ac65d85cbe593bdad886449e3807d950b234e77c675a0f7ca3b7c781"
},
"name": "smartscreen.exe",
"parent": {
"args": [
"svchost.exe",
"-k",
"DcomLaunch",
"-p"
],
"args_count": 4,
"code_signature": {
"status": "Valid"
},
"command_line": "svchost.exe -k DcomLaunch -p",

daverick and others added 2 commits January 12, 2024 14:48
Co-authored-by: Krishna Chaitanya Reddy Burri <krishnachaitanyareddy.burri@elastic.co>
@elasticmachine
Copy link

🚀 Benchmarks report

Package m365_defender 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 723.07 578.03 -145.04 (-20.06%) 💔

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@kcreddy kcreddy merged commit c91fc59 into main Jan 12, 2024
3 checks passed
@elasticmachine
Copy link

Package m365_defender - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender

@daverick daverick deleted the daverick-patch-1-2 branch January 15, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:m365_defender Microsoft M365 Defender
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants