-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M365 Defender integration - fix on process.command_line #8872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an entry into changelog.yml
like this: https://github.com/elastic/integrations/blob/main/packages/m365_defender/changelog.yml#L12-L16. Since this is a bugfix, the version here would be 2.5.1
Can you also update manifest.yml
here with version 2.5.1
?
@kcreddy done. |
/test |
After the change to the painless script, your change is valid according to this block of code: Lines 988 to 1013 in cc9a87e
|
Co-authored-by: Krishna Chaitanya Reddy Burri <krishnachaitanyareddy.burri@elastic.co>
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
event |
723.07 | 578.03 | -145.04 (-20.06%) | 💔 |
To see the full report comment with /test benchmark fullreport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Package m365_defender - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
process.command_line
was overwritten byprocess.parent.command_line
due to a typo in the script parsing the parent.command lineProposed commit message
fix process.command_line overwritten by process.parent.command_line
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots