Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nagios_xi: fix handling of potentially null method call receivers #9003

Merged
merged 2 commits into from
Jan 31, 2024
Merged

nagios_xi: fix handling of potentially null method call receivers #9003

merged 2 commits into from
Jan 31, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 30, 2024

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:nagios_xi Nagios XI bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Jan 30, 2024
@efd6 efd6 self-assigned this Jan 30, 2024
@efd6 efd6 mentioned this pull request Jan 30, 2024
Open
39 tasks
@elasticmachine
Copy link

elasticmachine commented Jan 30, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review January 30, 2024 05:25
@efd6 efd6 requested a review from a team as a code owner January 30, 2024 05:25
ShourieG
ShourieG approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

muthu-mps
muthu-mps reviewed Jan 31, 2024
View reviewed changes
packages/nagios_xi/data_stream/service/elasticsearch/ingest_pipeline/default.yml
@@ -681,7 +703,7 @@ processors:

- remove:
field: event.original
if: "ctx?.tags == null || !(ctx.tags.contains('preserve_original_event'))"
if: "ctx.tags == null || !(ctx.tags.contains('preserve_original_event'))"
Copy link
Contributor

@muthu-mps muthu-mps Jan 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make this change in the events datastream? This way the change becomes consistent across all datastreams.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stretching scope, but done.

@muthu-mps muthu-mps self-requested a review January 31, 2024 06:16
muthu-mps
muthu-mps approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit 41e522e into elastic:main Jan 31, 2024
3 checks passed
@elasticmachine
Copy link

Package nagios_xi - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=nagios_xi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthu-mps muthu-mps muthu-mps approved these changes

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue Integration:nagios_xi Nagios XI Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @elasticmachine @muthu-mps @ShourieG