Add secrets support to the Azure Logs integration #9022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrets require: - package-spec 3.0.2 - stack 8.10.0
Define `connection_string` and `storage_account_key` as secrets.
Kibana supports secrets from 8.10.0. However, stack versions in the 8.10.0 - 8.11.2 range have known bugs [^1] on secrets management. The recommended minimum stack version to use secrets is now 8.11.2. [^1]: See elastic#8610
With package-spec 3.0.1, the updated validators caught some missing field mappings. The missing fields are: - `azure.auditlogs.properties.additional_details.key` - `azure.auditlogs.properties.additional_details.value` The `AuditLogs` docs [^1] don't provide much details about the content of the `AdditionalDetails` field, reporting its type as `dynamic.` I am adding these two fields with a generic description for now. [^1]: https://learn.microsoft.com/en-us/azure/azure-monitor/reference/tables/auditlogs
🚀 Benchmarks reportTo see the full report comment with |
axw
approved these changes
Feb 1, 2024
gizas
approved these changes
Feb 1, 2024
|
@zmoog seeing last email answer that targeted version is ^8.12.0, wondering if you should change it as well |
ritalwar
approved these changes
Feb 5, 2024
According to the latest recommendations [^1], 8.12.0 contains all the known issues. [^1]: elastic#8610 (comment)
|
💚 Build Succeeded
History
cc @zmoog |
|
Package azure - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=azure |
4 tasks
4 tasks
zmoog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
connection_stringandstorage_account_keyvariables as secrets.3.0.2(secrets requirement)^8.12.0(^8.10.0to get secrets support,^8.12.0to avoid known bugs)This ensures their values are encrypted and hidden from the settings UI in Kibana, significantly enhancing security.
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Screenshots