Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Logs: set field type to password on secret fields #9159

Merged
merged 2 commits into from Feb 15, 2024
Merged

Azure Logs: set field type to password on secret fields #9159

merged 2 commits into from Feb 15, 2024

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Feb 14, 2024 •
edited

Proposed commit message

Update the field type from text to password on fields marked as secret.

The connection_string and storage_account_key have been marked as secret in the previous PR #9022, but I did not update the field type as password.

AFAIK, leaving the type as text does not have side effects; however, I want to align the field type with the semantics.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@zmoog
Set field type to password on secret fields
4900837 
The `connection_string` and `storage_account_key` have been marked as
`secret` in a previous PR, but I did not update the field type as
password.

AFAIK leaving the type as text does not have side effects, but I
I should align the field type with the semantics.
@zmoog zmoog self-assigned this Feb 14, 2024
@zmoog zmoog added bug Something isn't working Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Feb 14, 2024
@zmoog zmoog marked this pull request as ready for review February 14, 2024 22:17
@zmoog zmoog requested review from a team as code owners February 14, 2024 22:17
@elasticmachine
Copy link

elasticmachine commented Feb 14, 2024 •
edited

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @zmoog

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@zmoog zmoog merged commit 7df51d8 into elastic:main Feb 15, 2024
5 checks passed
@zmoog zmoog deleted the zmoog/fix-password-field-type-in-azure-logs branch February 15, 2024 09:01
@elasticmachine
Copy link

Package azure - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizas gizas gizas approved these changes

Assignees

@zmoog zmoog

Labels
bug Something isn't working Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmoog @elasticmachine @gizas