Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbon Black Cloud] - Fix @timestamp value by changing source to device_timestamp #9380

Merged
merged 17 commits into from Mar 18, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Mar 18, 2024

Type of change

  • Bug

Proposed commit message

Till now the @timestamp value was created with the create_time value. But after some discussions internally it was found that this was incorrect as this is the time at which the event gets ingested into carbon black cloud. The correct source for the timestamp value is device_timestamp which is the time at which the event is detected by the device and reported. Changes have made to reflect this, and at the same time a new field has been introduced called create_time which mirrors the original create_time value so that data integrity is maintained with the original event.

NOTE

Please ignore the older commit history, as the branch was already existing locally without any changes from before but had merge commits as a result of merging upstream/main multiple times. Only the last few commits matter.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Test Results

--- Test results for package: carbon_black_cloud - START ---
╭────────────────────┬─────────────────────────────┬───────────┬──────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE            │ DATA STREAM                 │ TEST TYPE │ TEST NAME                            │ RESULT │ TIME ELAPSED │
├────────────────────┼─────────────────────────────┼───────────┼──────────────────────────────────────┼────────┼──────────────┤
│ carbon_black_cloud │ alert                       │ pipeline  │ test-alert.log                       │ PASS   │    5.53725ms │
│ carbon_black_cloud │ asset_vulnerability_summary │ pipeline  │ test-asset-vulnerability-summary.log │ PASS   │   3.936875ms │
│ carbon_black_cloud │ audit                       │ pipeline  │ test-audit.log                       │ PASS   │   2.873917ms │
│ carbon_black_cloud │ endpoint_event              │ pipeline  │ test-endpoint-event.log              │ PASS   │   9.628666ms │
│ carbon_black_cloud │ watchlist_hit               │ pipeline  │ test-watchlist-hit.log               │ PASS   │   7.502125ms │
╰────────────────────┴─────────────────────────────┴───────────┴──────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: carbon_black_cloud - END   ---

@ShourieG ShourieG requested a review from a team as a code owner March 18, 2024 15:01
@ShourieG ShourieG self-assigned this Mar 18, 2024
@ShourieG ShourieG added integration Label used for meta issues tracking each integration bugfix labels Mar 18, 2024
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Mar 18, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @ShourieG

Copy link

Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit 43dc271 into elastic:main Mar 18, 2024
5 checks passed
@ShourieG ShourieG deleted the bugfix/carbon_black_cloud branch March 18, 2024 16:26
@elasticmachine
Copy link

Package carbon_black_cloud - 1.21.2 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carbon Black Cloud - Fix timestamp value
3 participants