Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbon Black Cloud] - Added support for more @timestamp formats #9391

Merged
merged 18 commits into from
Mar 20, 2024

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Mar 20, 2024

Type of change

  • Bug

Proposed commit message

Added support for more timestamp formats. These patterns were decided after discussing with a customer on different date patterns they were encountering in realtime.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

NOTE

Please ignore the older commit history, there's a local git history cleanup/rebase required (holding off atm). Only the last few commits matter.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Test Results

--- Test results for package: carbon_black_cloud - START ---
╭────────────────────┬─────────────────────────────┬───────────┬──────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE            │ DATA STREAM                 │ TEST TYPE │ TEST NAME                            │ RESULT │ TIME ELAPSED │
├────────────────────┼─────────────────────────────┼───────────┼──────────────────────────────────────┼────────┼──────────────┤
│ carbon_black_cloud │ alert                       │ pipeline  │ test-alert.log                       │ PASS   │    5.53725ms │
│ carbon_black_cloud │ asset_vulnerability_summary │ pipeline  │ test-asset-vulnerability-summary.log │ PASS   │   3.936875ms │
│ carbon_black_cloud │ audit                       │ pipeline  │ test-audit.log                       │ PASS   │   2.873917ms │
│ carbon_black_cloud │ endpoint_event              │ pipeline  │ test-endpoint-event.log              │ PASS   │   9.628666ms │
│ carbon_black_cloud │ watchlist_hit               │ pipeline  │ test-watchlist-hit.log               │ PASS   │   7.502125ms │
╰────────────────────┴─────────────────────────────┴───────────┴──────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: carbon_black_cloud - END   ---

@ShourieG ShourieG requested a review from a team as a code owner March 20, 2024 02:11
@ShourieG ShourieG self-assigned this Mar 20, 2024
@ShourieG ShourieG added integration Label used for meta issues tracking each integration bugfix Pull request that fixes a bug issue Team:Service-Integrations Label for the Service Integrations team Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Mar 20, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG enabled auto-merge (squash) March 20, 2024 02:16
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @ShourieG

Copy link

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an explanation to the commit message of why the relaxation is needed. The linked issues don't show that it's required.

@ShourieG ShourieG merged commit d16efc6 into elastic:main Mar 20, 2024
5 checks passed
@efd6
Copy link
Contributor

efd6 commented Mar 20, 2024

Too late

@elasticmachine
Copy link

Package carbon_black_cloud - 1.21.3 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud

@ShourieG
Copy link
Contributor Author

@efd6 thanks for the input, I had automerge enabled so it was too late by the time I saw the comment. I've expanded the PR description stating why it was done.

@ShourieG ShourieG deleted the cbc/timestamp_enhancement branch March 20, 2024 09:28
@andrewkroh andrewkroh added the Integration:carbon_black_cloud VMware Carbon Black Cloud label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:carbon_black_cloud VMware Carbon Black Cloud integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants