-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fortigate logs parsing with kafka logstash #9438
Fortigate logs parsing with kafka logstash #9438
Conversation
- At some point, the `event.original_message` field is populated before the integration gets the event, causing the integration to not perform the copy from `message`, which breaks all the processing. This changes the copy to a `set` and `remove`, since we do not actually care what was in `event.original_message` before the integration gets the event. - Added a test that looks very much like what the customer was seeing. - Old tests continue to pass; new test passes.
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a minor nit about the changelog message.
Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com>
💚 Build Succeeded
History
|
|
Package fortinet_fortigate - 1.25.1 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate |
Proposed commit message
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
elastic-package test pipeline
in thepackages/fortinet_fortigate
directory verifies the update and new test case.Related issues
Screenshots