Conversation
@sqren, outside of adding this to the docker whitelist |
@tylersmalley Ahh, I think you are right. Something just dawned on me - correct me if the following is wrong:
So in short:
|
|
@sqren, yup that's exactly correct. This PR LGTM and https://github.com/elastic/x-pack-kibana/pull/4489 can be closed since Kibana handles it internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the help and persistence here.
APM in x-pack currently uses
xpack.apm.ui.enabled
but the plan is to move toxpack.apm.enabled
for consistency with the other options. Since this is a breaking change we have to keep both until 7.0 before we can removexpack.apm.ui.enabled
.cc @dadoonet
This is dependent on https://github.com/elastic/x-pack-kibana/pull/4489