[Synthetics] remove hydrating saved objects (#140545)

* synthetics - remove hydrating saved objects

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* remove logic to set url back to empty string

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

x-pack/plugins/synthetics/server/routes/monitor_cruds/edit_monitor.ts

@@ -20,7 +20,6 @@ import {
   SyntheticsMonitorWithSecrets,
   SyntheticsMonitor,
   ConfigKey,
-  FormMonitorType,
 } from '../../../common/runtime_types';
 import { SyntheticsRestApiRouteFactory } from '../../legacy_uptime/routes/types';
 import { API_URLS } from '../../../common/constants';
@@ -146,10 +145,7 @@ export const syncEditedMonitor = async ({
     const editedSOPromise = savedObjectsClient.update<MonitorFields>(
       syntheticsMonitorType,
       previousMonitor.id,
-      monitorWithRevision.type === 'browser' &&
-        monitorWithRevision[ConfigKey.FORM_MONITOR_TYPE] !== FormMonitorType.SINGLE
-        ? { ...monitorWithRevision, urls: '' }
-        : monitorWithRevision
+      monitorWithRevision
     );
 
     const editSyncPromise = syntheticsMonitorClient.editMonitor(

x-pack/plugins/synthetics/server/synthetics_service/synthetics_service.ts

@@ -42,8 +42,6 @@ import {
   HeartbeatConfig,
 } from '../../common/runtime_types';
 import { getServiceLocations } from './get_service_locations';
-import { hydrateSavedObjects } from './hydrate_saved_object';
-import { DecryptedSyntheticsMonitorSavedObject } from '../../common/types';
 
 import { normalizeSecrets } from './utils/secrets';
 
@@ -475,14 +473,6 @@ export class SyntheticsService {
       monitors: monitors.length,
     });
 
-    if (this.indexTemplateExists) {
-      // without mapping, querying won't make sense
-      hydrateSavedObjects({
-        monitors: monitors as unknown as DecryptedSyntheticsMonitorSavedObject[],
-        server: this.server,
-      });
-    }
-
     return (monitors ?? []).map((monitor) => {
       const attributes = monitor.attributes as unknown as MonitorFields;
       return formatHeartbeatRequest({