[Synthetics] remove hydrating saved objects #140545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiqueclarke
force-pushed
the
fix/synthetics-deprecate-hydrating-saved-objects
branch
from
c6f49f6
to
52056b1
Compare
…-ref HEAD~1..HEAD --fix'
dominiqueclarke
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
|
@elasticmachine merge upstream |
…tps://github.com/dominiqueclarke/kibana into fix/synthetics-deprecate-hydrating-saved-objects
…-ref HEAD~1..HEAD --fix'
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
shahzad31
approved these changes
Sep 13, 2022
dominiqueclarke
deleted the
fix/synthetics-deprecate-hydrating-saved-objects
branch
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
dominiqueclarke
added a commit
to dominiqueclarke/kibana
that referenced
this pull request
Sep 13, 2022
* synthetics - remove hydrating saved objects * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * remove logic to set url back to empty string * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0ecd3fa) # Conflicts: # x-pack/plugins/synthetics/server/routes/monitor_cruds/edit_monitor.ts # x-pack/plugins/synthetics/server/synthetics_service/hydrate_saved_object.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dominiqueclarke
added a commit
that referenced
this pull request
Sep 14, 2022
* [Synthetics] remove hydrating saved objects (#140545) * synthetics - remove hydrating saved objects * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * remove logic to set url back to empty string * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0ecd3fa) # Conflicts: # x-pack/plugins/synthetics/server/routes/monitor_cruds/edit_monitor.ts # x-pack/plugins/synthetics/server/synthetics_service/hydrate_saved_object.ts * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Update x-pack/plugins/synthetics/server/routes/monitor_cruds/edit_monitor.ts * Update x-pack/plugins/synthetics/server/synthetics_service/project_monitor_formatter.ts Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
|
Mostly a tech debt/code removal, so skipping post ff testing !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes hydration for synthetics monitor saved objects.
Hydration has historically been used to add
urlandportfields to browser, tcp, and http monitors. However, given that this flow is prone to bugs, and offers little value, we are removing the feature entirely.