Skip to content

Commit

Permalink
[Security Solution][Endpoint] Update description list on endpoint det…
Browse files Browse the repository at this point in the history
…ails flyout (#165937)

## Summary

This PR fixes a UX bug that was a result of EUI upgrade where the
description list contents were misaligned. The `EuiDescriptionList`
component should take a set of column widths and column and row gutter
sizes to allow for adequate spacing between text elements.

**before**
![Screenshot 2023-09-07 at 10 16 11
AM](https://github.com/elastic/kibana/assets/1849116/80984552-b611-40ea-98c5-945aa3b179d7)

**with this fix**
![Screenshot 2023-09-07 at 10 15 26
AM](https://github.com/elastic/kibana/assets/1849116/fe1fd47f-8905-4808-bd14-f891fc345a2b)


see /pull/165047

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
  • Loading branch information
ashokaditya committed Sep 7, 2023
1 parent 3ec119f commit 1c62d1c
Showing 1 changed file with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,6 @@ import { EndpointPolicyLink } from '../../../../components/endpoint_policy_link'
import { OutOfDate } from '../components/out_of_date';

const EndpointDetailsContentStyled = styled.div`
dl dt {
max-width: 27%;
}
dl dd {
max-width: 73%;
}
.policyLineText {
padding-right: 5px;
}
Expand Down Expand Up @@ -239,7 +231,9 @@ export const EndpointDetailsContent = memo<EndpointDetailsContentProps>(
<EndpointDetailsContentStyled>
<EuiSpacer size="s" />
<EuiDescriptionList
compressed={true}
columnWidths={[1, 3]}
compressed
rowGutterSize="m"
type="column"
listItems={detailsResults}
data-test-subj="endpointDetailsList"
Expand Down

0 comments on commit 1c62d1c

Please sign in to comment.