-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Endpoint] Update description list on endpoint details flyout #165937
Merged
ashokaditya
merged 5 commits into
elastic:main
from
ashokaditya:fix/dw-endpoint-details-flyout-7563
Sep 7, 2023
Merged
[Security Solution][Endpoint] Update description list on endpoint details flyout #165937
ashokaditya
merged 5 commits into
elastic:main
from
ashokaditya:fix/dw-endpoint-details-flyout-7563
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
tomsonpl
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome fix! Thanks :)
gergoabraham
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@elasticmachine merge upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
OLM Sprint
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a UX bug that was a result of EUI upgrade where the description list contents were misaligned. The
EuiDescriptionList
component should take a set of column widths and column and row gutter sizes to allow for adequate spacing between text elements.before
![Screenshot 2023-09-07 at 10 16 11 AM](https://private-user-images.githubusercontent.com/1849116/266251787-80984552-b611-40ea-98c5-945aa3b179d7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNzUwNDIsIm5iZiI6MTcyMTI3NDc0MiwicGF0aCI6Ii8xODQ5MTE2LzI2NjI1MTc4Ny04MDk4NDU1Mi1iNjExLTQwZWEtOThjNS05NDVhYTNiMTc5ZDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MThUMDM1MjIyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MmM5MGQzYzQyMjgwZGI5Yjc0NWYwZDExNWYxOWE4NzJiY2FkMTNkM2ZmZDRmNzk3ZGZlODRlNTc2ZjkyYmZiMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.v6z8YPrB-o1MjUurVugOzgrj0jSXn6-kbgY526G1-Lg)
with this fix
![Screenshot 2023-09-07 at 10 15 26 AM](https://private-user-images.githubusercontent.com/1849116/266251553-fe1fd47f-8905-4808-bd14-f891fc345a2b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyNzUwNDIsIm5iZiI6MTcyMTI3NDc0MiwicGF0aCI6Ii8xODQ5MTE2LzI2NjI1MTU1My1mZTFmZDQ3Zi04OTA1LTQ4MDgtYmQxNC1mODkxZmMzNDVhMmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MThUMDM1MjIyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTZiMjhiNDM1N2I4YjZkZTY3OGIwNTEwMDBjYzBhZWE4MDUzZjM2YWJjOWMyZTg1MmRhYzI0MjU1NDc1YTA5ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.V-vgOgo4t7jdoHpoRp_TQ01DvtX3niyaCtR9K1OI1IE)
see /pull/165047
Checklist