Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Update description list on endpoint details flyout #165937

Merged

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Sep 7, 2023

Summary

This PR fixes a UX bug that was a result of EUI upgrade where the description list contents were misaligned. The EuiDescriptionList component should take a set of column widths and column and row gutter sizes to allow for adequate spacing between text elements.

before
Screenshot 2023-09-07 at 10 16 11 AM

with this fix
Screenshot 2023-09-07 at 10 15 26 AM

see /pull/165047

Checklist

@ashokaditya ashokaditya self-assigned this Sep 7, 2023
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.11.0 labels Sep 7, 2023
@ashokaditya ashokaditya marked this pull request as ready for review September 7, 2023 08:17
@ashokaditya ashokaditya requested a review from a team as a code owner September 7, 2023 08:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix! Thanks :)

Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ashokaditya ashokaditya enabled auto-merge (squash) September 7, 2023 09:24
@ashokaditya
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 7, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Columns selection initialization and update "after all" hook in "Columns selection initialization and update"
  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Columns selection initialization and update "before all" hook in "Columns selection initialization and update"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB -5.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit 1c62d1c into elastic:main Sep 7, 2023
31 of 45 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 7, 2023
@ashokaditya ashokaditya deleted the fix/dw-endpoint-details-flyout-7563 branch September 7, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants