[build/fs] Fix copyAll default atime and mtime (#88921)

elastic · Jan 21, 2021 · 2d86004 · 2d86004
1 parent 5ec099a
commit 2d86004
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/dev/build/lib/fs.ts b/src/dev/build/lib/fs.ts
@@ -153,15 +153,15 @@ export async function copy(source: string, destination: string, options: CopyOpt
 interface CopyAllOptions {
   select?: string[];
   dot?: boolean;
-  time?: string | number | Date;
+  time?: Date;
 }
 
 export async function copyAll(
   sourceDir: string,
   destination: string,
   options: CopyAllOptions = {}
 ) {
-  const { select = ['**/*'], dot = false, time = Date.now() } = options;
+  const { select = ['**/*'], dot = false, time = new Date() } = options;
 
   assertAbsolute(sourceDir);
   assertAbsolute(destination);

diff --git a/src/dev/build/lib/integration_tests/fs.test.ts b/src/dev/build/lib/integration_tests/fs.test.ts
@@ -244,6 +244,20 @@ describe('copyAll()', () => {
     expect(Math.abs(fooDir.atimeMs - time.getTime())).toBeLessThan(oneDay);
     expect(Math.abs(barTxt.mtimeMs - time.getTime())).toBeLessThan(oneDay);
   });
+
+  it('defaults atime and mtime to now', async () => {
+    const destination = resolve(TMP, 'a/b/c/d/e/f');
+    await copyAll(FIXTURES, destination);
+    const barTxt = statSync(resolve(destination, 'foo_dir/bar.txt'));
+    const fooDir = statSync(resolve(destination, 'foo_dir'));
+
+    // precision is platform specific
+    const now = new Date();
+    const oneDay = 86400000;
+    expect(Math.abs(barTxt.atimeMs - now.getTime())).toBeLessThan(oneDay);
+    expect(Math.abs(fooDir.atimeMs - now.getTime())).toBeLessThan(oneDay);
+    expect(Math.abs(barTxt.mtimeMs - now.getTime())).toBeLessThan(oneDay);
+  });
 });
 
 describe('getFileHash()', () => {