-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build/fs] Fix copyAll default atime and mtime #88921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
approved these changes
Jan 20, 2021
jbudz
added
release_note:skip
Skip the PR/issue when compiling release notes
and removed
release_note:fix
labels
Jan 20, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
spalger
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbudz
added a commit
that referenced
this pull request
Jan 21, 2021
jbudz
added a commit
that referenced
this pull request
Jan 21, 2021
jbudz
added a commit
that referenced
this pull request
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.10.3
v7.11.0
v7.12.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying files during builds we're passing a default of
Date.now()
(time since epoch in ms) tofs.utimes
. fs.utimes expects this argument to be in seconds. This can result in a corrupt timestamp on file access and file modified:Behavior appears to be inconsistent across build environments. Locally, I'm setting the year to 2446, in contrast to the 7.11.0 BC above with a year of 1969.