Skip to content

Commit

Permalink
Disables response logging as a default (#42353)
Browse files Browse the repository at this point in the history
Previously, if any of the following were true, we would log HTTP responses.
- `logging.json` was set
- `logging.dest` was set
- `TTY` was detected

The logging format should not dictate what is logged

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
  • Loading branch information
Tyler Smalley committed Aug 12, 2019
1 parent f7a71f2 commit 372b79e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 6 additions & 0 deletions docs/migration/migrate_8_0.asciidoc
Expand Up @@ -48,6 +48,12 @@ for example, `logstash-*`.

*Impact:* To restore the previous behavior, in kibana.yml set `logging.timezone: UTC`.

[float]
==== Responses are never logged by default
*Details:* Previously responses would be logged if either `logging.json` was true, `logging.dest` was specified, or a `TTY` was detected.

*Impact:* To restore the previous behavior, in kibana.yml set `logging.events.response=*`.

[float]
==== `xpack.security.authProviders` is no longer valid
*Details:* The deprecated `xpack.security.authProviders` setting in the `kibana.yml` file has been removed.
Expand Down
1 change: 0 additions & 1 deletion src/legacy/server/logging/configuration.js
Expand Up @@ -45,7 +45,6 @@ export default function loggingConfiguration(config) {
else {
_.defaults(events, {
log: ['info', 'warning', 'error', 'fatal'],
response: config.get('logging.json') ? '*' : '!',
request: ['info', 'warning', 'error', 'fatal'],
error: '*'
});
Expand Down

0 comments on commit 372b79e

Please sign in to comment.