Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution][Detections] fixes various timeline components iss…
…ues (#135907) ## Summary Addresses: #128740 ### 1. Responsiveness #### Before > It doesn't look good on a smaller screen: <p align="center"> <img width="300" src="https://puu.sh/IRpyP/eb7bebabc7.png" /> </p> #### After <p align="center"> <img width="501" alt="Screenshot 2022-07-08 at 16 57 13" src="https://user-images.githubusercontent.com/92328789/178028639-aca44597-b6d3-4234-be08-6cbd435afe44.png"> </p> ### 2. Focus #### Before > Its focus state seems off and doesn't match the combo box focus state (it's especially noticeable in Dark Mode). <p align="center"> <img width="300" src="https://user-images.githubusercontent.com/2946766/160513096-73cda874-057c-48da-9ac3-97db48ca78b1.gif" /> </p> #### After https://user-images.githubusercontent.com/92328789/178028779-ac268478-3f3d-4c13-9699-df9510e21ce5.mov ### 3. Clicking on "favorite star" #### Before > If you click the "favorite star" when selecting the first component it can't be reselected until focus is lost: <p align="center"> <img width="300" src="https://user-images.githubusercontent.com/2946766/160513715-9a4e251a-e071-47ce-b5e8-cdc5ed302e33.gif" /> </p> #### After https://user-images.githubusercontent.com/92328789/178028779-ac268478-3f3d-4c13-9699-df9510e21ce5.mov > Within Edit Rules (also notice how it re-open after selection....weird): Haven't found way to mitigate this, but anyway it doesn't impact heavily user experience or causes significant impact. So, I left it as it is. #### 4.Search bar placeholder text #### Before > It's not fully visible, and we should either make it shorter or truncate with ellipsis like we do in other parts of the UI: ![](https://user-images.githubusercontent.com/81987435/163236197-15aca8cb-8f71-485c-9b03-37900c0675c4.png) #### After More details on trimming of placeholder [here](#128740 (comment)) <img width="1529" alt="Screenshot 2022-07-11 at 18 29 01" src="https://user-images.githubusercontent.com/92328789/178323118-d2c437fd-6027-4ac0-bb42-532d524ac8db.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Release note fixes multiple small issues with timeline template selector used on rule edit page and bulk edit
- Loading branch information