Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Timeline template selector rendering issues #128740

Closed
banderror opened this issue Mar 29, 2022 · 5 comments · Fixed by #135907
Closed

[Security Solution] Timeline template selector rendering issues #128740

banderror opened this issue Mar 29, 2022 · 5 comments · Fixed by #135907
Assignees
Labels
8.4 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0

Comments

@banderror
Copy link
Contributor

banderror commented Mar 29, 2022

Summary

The timeline template selector has some issues with rendering. It's a reusable <PickTimeline> component used in the rule creation/editing forms, bulk applying timeline template form, etc.

Responsiveness

It doesn't look good on a smaller screen:

Focus

Its focus state seems off and doesn't match the combo box focus state from EUI here (it's especially noticeable in Dark Mode).

Within bulk apply timeline template flyout:

Within Edit Rules (also notice how it re-open after selection....weird):

Clicking on "favorite star"

If you click the "favorite star" when selecting the first component it can't be reselected until focus is lost:

Search bar placeholder text

It's not fully visible, and we should either make it shorter or truncate with ellipsis like we do in other parts of the UI:

Other issues with this component

@banderror banderror added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Mar 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@yiyangliu9286
Copy link

Hi @banderror, thanks for providing the screenshot for UIs and interactions. This looks great.
There's only a small design fix that I'd suggest if we could update the default text in the search bar under "Apply Timeline template to selected rules" to be overflow "..." instead texts being cut off, that would be great.
Screen Shot 2022-04-12 at 3 49 27 PM

@vitaliidm
Copy link
Contributor

vitaliidm commented Jul 6, 2022

Search bar placeholder text
It's not fully visible, and we should either make it shorter or truncate with ellipsis like we do in other parts of the UI:

When input is in focus(which is almost always a true for our case, because even when users navigate through options with arrow buttons, input still in focus), placeholder is not getting trimmed with ellipsis. Here is some details on that on stackoverflow.

Moreover, given that the width of input won't change at all, because it displayed in short width flyout in EuiFormRow of fixed width(400px, https://elastic.github.io/eui/#/forms/form-layouts), user won't be able ever to read the whole description. I would suggest to keep it as short as possible to mitigate this:
Let's say instead of "Apply Timeline template to selected rules", which will be trimmed, let's use ""Apply Timeline template" or "Search Timeline template"(would vote for this one, as there are already "Apple Timeline .." on the form(as select label and form title)

Here is, how it will be displayed on a screen:
Screenshot 2022-07-06 at 12 40 14

Same might go for edit/create rule screen as well. Any suggestions on that?

cc: @yiyangliu9286, @banderror

@vitaliidm
Copy link
Contributor

issues are addressed in #135907

But overall feeling after working on this component: we should consider replacing it with https://elastic.github.io/eui/#/forms/combo-box.
I haven't researched if it possible and what was the reasoning behind not using it but rather create a separate component, but it certainly worth to discuss

vitaliidm added a commit that referenced this issue Jul 13, 2022
…ues (#135907)

## Summary

Addresses: #128740

### 1. Responsiveness

#### Before
> It doesn't look good on a smaller screen:

<p align="center">
  <img width="300" src="https://puu.sh/IRpyP/eb7bebabc7.png" />
</p>

#### After
<p align="center">
<img width="501" alt="Screenshot 2022-07-08 at 16 57 13" src="https://user-images.githubusercontent.com/92328789/178028639-aca44597-b6d3-4234-be08-6cbd435afe44.png">
</p>

### 2. Focus

#### Before
> Its focus state seems off and doesn't match the combo box focus state (it's especially noticeable in Dark Mode).

<p align="center">
  <img width="300" src="https://user-images.githubusercontent.com/2946766/160513096-73cda874-057c-48da-9ac3-97db48ca78b1.gif" />
</p>

#### After

https://user-images.githubusercontent.com/92328789/178028779-ac268478-3f3d-4c13-9699-df9510e21ce5.mov

### 3. Clicking on "favorite star"

#### Before
> If you click the "favorite star" when selecting the first component it can't be reselected until focus is lost:

<p align="center">
  <img width="300" src="https://user-images.githubusercontent.com/2946766/160513715-9a4e251a-e071-47ce-b5e8-cdc5ed302e33.gif" />
</p>

#### After

https://user-images.githubusercontent.com/92328789/178028779-ac268478-3f3d-4c13-9699-df9510e21ce5.mov

> Within Edit Rules (also notice how it re-open after selection....weird):

Haven't found way to mitigate this, but anyway it doesn't impact heavily user experience or causes significant impact. So, I left it as it is.

#### 4.Search bar placeholder text
#### Before
> It's not fully visible, and we should either make it shorter or truncate with ellipsis like we do in other parts of the UI:

![](https://user-images.githubusercontent.com/81987435/163236197-15aca8cb-8f71-485c-9b03-37900c0675c4.png)

#### After
More details on trimming of placeholder [here](#128740 (comment))
<img width="1529" alt="Screenshot 2022-07-11 at 18 29 01" src="https://user-images.githubusercontent.com/92328789/178323118-d2c437fd-6027-4ac0-bb42-532d524ac8db.png">

### Checklist

Delete any items that are not applicable to this PR.

- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Release note
fixes multiple small issues with timeline template selector used on rule edit page and bulk edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.4 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants