-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Timeline template selector rendering issues #128740
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Hi @banderror, thanks for providing the screenshot for UIs and interactions. This looks great. |
When input is in focus(which is almost always a true for our case, because even when users navigate through options with arrow buttons, input still in focus), placeholder is not getting trimmed with ellipsis. Here is some details on that on stackoverflow. Moreover, given that the width of input won't change at all, because it displayed in short width flyout in EuiFormRow of fixed width(400px, https://elastic.github.io/eui/#/forms/form-layouts), user won't be able ever to read the whole description. I would suggest to keep it as short as possible to mitigate this: Here is, how it will be displayed on a screen: Same might go for edit/create rule screen as well. Any suggestions on that? cc: @yiyangliu9286, @banderror |
issues are addressed in #135907 But overall feeling after working on this component: we should consider replacing it with https://elastic.github.io/eui/#/forms/combo-box. |
…ues (#135907) ## Summary Addresses: #128740 ### 1. Responsiveness #### Before > It doesn't look good on a smaller screen: <p align="center"> <img width="300" src="https://puu.sh/IRpyP/eb7bebabc7.png" /> </p> #### After <p align="center"> <img width="501" alt="Screenshot 2022-07-08 at 16 57 13" src="https://user-images.githubusercontent.com/92328789/178028639-aca44597-b6d3-4234-be08-6cbd435afe44.png"> </p> ### 2. Focus #### Before > Its focus state seems off and doesn't match the combo box focus state (it's especially noticeable in Dark Mode). <p align="center"> <img width="300" src="https://user-images.githubusercontent.com/2946766/160513096-73cda874-057c-48da-9ac3-97db48ca78b1.gif" /> </p> #### After https://user-images.githubusercontent.com/92328789/178028779-ac268478-3f3d-4c13-9699-df9510e21ce5.mov ### 3. Clicking on "favorite star" #### Before > If you click the "favorite star" when selecting the first component it can't be reselected until focus is lost: <p align="center"> <img width="300" src="https://user-images.githubusercontent.com/2946766/160513715-9a4e251a-e071-47ce-b5e8-cdc5ed302e33.gif" /> </p> #### After https://user-images.githubusercontent.com/92328789/178028779-ac268478-3f3d-4c13-9699-df9510e21ce5.mov > Within Edit Rules (also notice how it re-open after selection....weird): Haven't found way to mitigate this, but anyway it doesn't impact heavily user experience or causes significant impact. So, I left it as it is. #### 4.Search bar placeholder text #### Before > It's not fully visible, and we should either make it shorter or truncate with ellipsis like we do in other parts of the UI: ![](https://user-images.githubusercontent.com/81987435/163236197-15aca8cb-8f71-485c-9b03-37900c0675c4.png) #### After More details on trimming of placeholder [here](#128740 (comment)) <img width="1529" alt="Screenshot 2022-07-11 at 18 29 01" src="https://user-images.githubusercontent.com/92328789/178323118-d2c437fd-6027-4ac0-bb42-532d524ac8db.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Release note fixes multiple small issues with timeline template selector used on rule edit page and bulk edit
Summary
The timeline template selector has some issues with rendering. It's a reusable
<PickTimeline>
component used in the rule creation/editing forms, bulk applying timeline template form, etc.Responsiveness
It doesn't look good on a smaller screen:
Focus
Its focus state seems off and doesn't match the combo box focus state from EUI here (it's especially noticeable in Dark Mode).
Within bulk apply timeline template flyout:
Within Edit Rules (also notice how it re-open after selection....weird):
Clicking on "favorite star"
If you click the "favorite star" when selecting the first component it can't be reselected until focus is lost:
Search bar placeholder text
It's not fully visible, and we should either make it shorter or truncate with ellipsis like we do in other parts of the UI:
Other issues with this component
The text was updated successfully, but these errors were encountered: