[Obs AI Assistant] Fix import issues from /public folders (#182940)

Make sure the evaluation script doesn't import from `public` folders that include code that cannot run in Node.js. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
elastic · May 13, 2024 · 551e123 · 551e123
1 parent f2945cf
commit 551e123
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/...ns/observability_solution/observability_ai_assistant_app/scripts/evaluation/evaluation.ts b/...ns/observability_solution/observability_ai_assistant_app/scripts/evaluation/evaluation.ts
@@ -19,7 +19,7 @@ import * as table from 'table';
 import { TableUserConfig } from 'table';
 import { format, parse } from 'url';
 import { ToolingLog } from '@kbn/tooling-log';
-import { MessageRole } from '@kbn/observability-ai-assistant-plugin/public';
+import { MessageRole } from '@kbn/observability-ai-assistant-plugin/common';
 import { EvaluateWith, options } from './cli';
 import { getServiceUrls } from './get_service_urls';
 import { KibanaClient } from './kibana_client';

diff --git a/...observability_solution/observability_ai_assistant_app/scripts/evaluation/kibana_client.ts b/...observability_solution/observability_ai_assistant_app/scripts/evaluation/kibana_client.ts
@@ -21,12 +21,10 @@ import {
 import type { ObservabilityAIAssistantScreenContext } from '@kbn/observability-ai-assistant-plugin/common/types';
 import { throwSerializedChatCompletionErrors } from '@kbn/observability-ai-assistant-plugin/common/utils/throw_serialized_chat_completion_errors';
 import {
-  APIReturnType,
   isSupportedConnectorType,
   Message,
   MessageRole,
-  ObservabilityAIAssistantAPIClientRequestParamsOf,
-} from '@kbn/observability-ai-assistant-plugin/public';
+} from '@kbn/observability-ai-assistant-plugin/common';
 import { streamIntoObservable } from '@kbn/observability-ai-assistant-plugin/server';
 import { ToolingLog } from '@kbn/tooling-log';
 import axios, { AxiosInstance, AxiosResponse, isAxiosError } from 'axios';
@@ -47,6 +45,10 @@ import {
 } from 'rxjs';
 import { format, parse, UrlObject } from 'url';
 import { inspect } from 'util';
+import type {
+  ObservabilityAIAssistantAPIClientRequestParamsOf,
+  APIReturnType,
+} from '@kbn/observability-ai-assistant-plugin/public';
 import { EvaluationResult } from './types';
 
 // eslint-disable-next-line spaced-comment

diff --git a/...solution/observability_ai_assistant_app/scripts/evaluation/scenarios/alerts/index.spec.ts b/...solution/observability_ai_assistant_app/scripts/evaluation/scenarios/alerts/index.spec.ts
@@ -11,7 +11,7 @@ import expect from '@kbn/expect';
 import { RuleResponse } from '@kbn/alerting-plugin/common/routes/rule/response/types/v1';
 import moment from 'moment';
 import { apm, timerange } from '@kbn/apm-synthtrace-client';
-import { MessageRole } from '@kbn/observability-ai-assistant-plugin/public';
+import { MessageRole } from '@kbn/observability-ai-assistant-plugin/common';
 import { chatClient, kibanaClient, synthtraceEsClients, logger } from '../../services';
 import {
   apmTransactionRateAIAssistant,

diff --git a/...ty_solution/observability_ai_assistant_app/scripts/evaluation/scenarios/apm/index.spec.ts b/...ty_solution/observability_ai_assistant_app/scripts/evaluation/scenarios/apm/index.spec.ts
@@ -11,7 +11,7 @@ import expect from '@kbn/expect';
 import moment from 'moment';
 import { apm, timerange, serviceMap } from '@kbn/apm-synthtrace-client';
 import { RuleResponse } from '@kbn/alerting-plugin/common/routes/rule/response/types/v1';
-import { MessageRole } from '@kbn/observability-ai-assistant-plugin/public';
+import { MessageRole } from '@kbn/observability-ai-assistant-plugin/common';
 import { chatClient, kibanaClient, synthtraceEsClients } from '../../services';
 import { apmErrorCountAIAssistant } from '../../alert_templates/templates';
 

diff --git a/...n/observability_ai_assistant_app/scripts/evaluation/scenarios/elasticsearch/index.spec.ts b/...n/observability_ai_assistant_app/scripts/evaluation/scenarios/elasticsearch/index.spec.ts
@@ -8,7 +8,7 @@
 /// <reference types="@kbn/ambient-ftr-types"/>
 
 import expect from '@kbn/expect';
-import { MessageRole } from '@kbn/observability-ai-assistant-plugin/public';
+import { MessageRole } from '@kbn/observability-ai-assistant-plugin/common';
 import { chatClient, esClient } from '../../services';
 
 describe('elasticsearch functions', () => {

diff --git a/...ity_solution/observability_ai_assistant_app/scripts/evaluation/scenarios/kb/index.spec.ts b/...ity_solution/observability_ai_assistant_app/scripts/evaluation/scenarios/kb/index.spec.ts
@@ -8,7 +8,7 @@
 /// <reference types="@kbn/ambient-ftr-types"/>
 
 import expect from '@kbn/expect';
-import { MessageRole } from '@kbn/observability-ai-assistant-plugin/public';
+import { MessageRole } from '@kbn/observability-ai-assistant-plugin/common';
 import { chatClient, esClient } from '../../services';
 
 describe('kb functions', () => {