Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Fix import issues from /public folders #182940

Merged
merged 2 commits into from
May 13, 2024
Merged

[Obs AI Assistant] Fix import issues from /public folders #182940

merged 2 commits into from
May 13, 2024

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented May 8, 2024 •
edited by kibanamachine
Loading

Make sure the evaluation script doesn't import from public folders that include code that cannot run in Node.js.

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels May 8, 2024
@dgieselaar dgieselaar self-assigned this May 8, 2024
@dgieselaar dgieselaar requested a review from a team as a code owner May 8, 2024 13:07
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 13, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dgieselaar

@dgieselaar dgieselaar merged commit 551e123 into elastic:main May 13, 2024
20 checks passed
@dgieselaar dgieselaar deleted the obs-ai-assistant-evaluation-imports branch May 13, 2024 11:44
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 13, 2024
@dgieselaar
[Obs AI Assistant] Fix import issues from /public folders (elastic#18…
502f4c4 
…2940)

Make sure the evaluation script doesn't import from `public` folders
that include code that cannot run in Node.js.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 551e123)
@kibanamachine kibanamachine mentioned this pull request May 13, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 13, 2024
@kibanamachine @dgieselaar
[8.14] [Obs AI Assistant] Fix import issues from /public folders (#18…
c4107bd 
…2940) (#183268)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Obs AI Assistant] Fix import issues from /public folders
(#182940)](#182940)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2024-05-13T11:44:43Z","message":"[Obs
AI Assistant] Fix import issues from /public folders (#182940)\n\nMake
sure the evaluation script doesn't import from `public` folders\r\nthat
include code that cannot run in Node.js.\r\n\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"551e1232b870654d036aff4d52f43443ee3ecf20","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Obs
AI
Assistant","ci:project-deploy-observability","v8.14.0","v8.15.0"],"title":"[Obs
AI Assistant] Fix import issues from /public
folders","number":182940,"url":"#182940
AI Assistant] Fix import issues from /public folders (#182940)\n\nMake
sure the evaluation script doesn't import from `public` folders\r\nthat
include code that cannot run in Node.js.\r\n\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"551e1232b870654d036aff4d52f43443ee3ecf20"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182940
AI Assistant] Fix import issues from /public folders (#182940)\n\nMake
sure the evaluation script doesn't import from `public` folders\r\nthat
include code that cannot run in Node.js.\r\n\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"551e1232b870654d036aff4d52f43443ee3ecf20"}}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@dgieselaar dgieselaar

Labels
bug Fixes for quality problems that affect the customer experience ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dgieselaar @apmmachine @kibana-ci @kibanamachine @sorenlouv