✅ Fix jest tests

elastic · Oct 17, 2022 · 5eb26e0 · 5eb26e0
1 parent 862931b
commit 5eb26e0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/x-pack/plugins/lens/public/datasources/form_based/form_based.test.ts b/x-pack/plugins/lens/public/datasources/form_based/form_based.test.ts
@@ -487,6 +487,12 @@ describe('IndexPattern Data Source', () => {
                 "partialRows": Array [
                   false,
                 ],
+                "probability": Array [
+                  1,
+                ],
+                "samplerSeed": Array [
+                  453225886,
+                ],
                 "timeFields": Array [
                   "timestamp",
                 ],
@@ -1631,6 +1637,7 @@ describe('IndexPattern Data Source', () => {
           },
         },
         currentIndexPatternId: '1',
+        sampling: 1,
       };
       expect(FormBasedDatasource.insertLayer(state, 'newLayer')).toEqual({
         ...state,
@@ -1640,6 +1647,7 @@ describe('IndexPattern Data Source', () => {
             indexPatternId: '1',
             columnOrder: [],
             columns: {},
+            sampling: 1,
           },
         },
       });

diff --git a/x-pack/plugins/lens/public/datasources/form_based/form_based_suggestions.test.tsx b/x-pack/plugins/lens/public/datasources/form_based/form_based_suggestions.test.tsx
@@ -176,6 +176,7 @@ function testInitialState(): FormBasedPrivateState {
     currentIndexPatternId: '1',
     layers: {
       first: {
+        sampling: 1,
         indexPatternId: '1',
         columnOrder: ['col1'],
         columns: {

diff --git a/x-pack/plugins/lens/public/datasources/form_based/form_based_suggestions.ts b/x-pack/plugins/lens/public/datasources/form_based/form_based_suggestions.ts
@@ -530,8 +530,9 @@ function getEmptyLayerSuggestionsForField(
   }
 
   // copy the sampling rate to the new layer
+  // or just default to 1
   if (newLayer) {
-    newLayer.sampling = state.layers[layerId].sampling;
+    newLayer.sampling = state.layers[layerId]?.sampling ?? 1;
   }
 
   const newLayerSuggestions = newLayer