Skip to content

Commit

Permalink
removes mockLogger declaration from individual test cases - clears mo…
Browse files Browse the repository at this point in the history 
…ck counts before each test case runs so as to not accumulate method calls after each test case
  • Loading branch information
@dhurley14
dhurley14 committed Nov 11, 2019
1 parent de3e718 commit 6941907
Showing 1 changed file with 18 additions and 209 deletions.
227 changes: 18 additions & 209 deletions x-pack/legacy/plugins/siem/server/lib/detection_engine/alerts/utils.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,25 @@ import {
import { SignalAlertParams } from './types';
import { buildEventsSearchQuery } from './build_events_query';

const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
describe('utils', () => {
beforeEach(() => {
jest.clearAllMocks();
});
describe('buildBulkBody', () => {
test('if bulk body builds well-defined body', () => {
const sampleParams: SignalAlertParams = sampleSignalAlertParams(undefined);
Expand Down Expand Up @@ -58,7 +76,6 @@ describe('utils', () => {
});
describe('singleBulkIndex', () => {
test('create successful bulk index', async () => {
// need a sample search result, sample signal params, mock service, mock logger
const sampleParams = sampleSignalAlertParams(undefined);
const sampleSearchResult = sampleDocSearchResultsNoSortId;
const savedObjectsClient = savedObjectsClientMock.create();
Expand Down Expand Up @@ -92,19 +109,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
fatal: jest.fn(),
log: jest.fn(),
};
const successfulSingleBulkIndex = await singleBulkIndex(
sampleSearchResult,
sampleParams,
Expand All @@ -128,19 +132,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
fatal: jest.fn(),
log: jest.fn(),
};
const successfulSingleBulkIndex = await singleBulkIndex(
sampleSearchResult,
sampleParams,
Expand Down Expand Up @@ -181,19 +172,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
fatal: jest.fn(),
log: jest.fn(),
};
const successfulSingleBulkIndex = await singleBulkIndex(
sampleSearchResult,
sampleParams,
Expand Down Expand Up @@ -230,19 +208,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
fatal: jest.fn(),
log: jest.fn(),
};
try {
const searchAfterResult = await singleSearchAfter(
searchAfterSortId,
Expand Down Expand Up @@ -278,19 +243,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
fatal: jest.fn(),
log: jest.fn(),
};
const searchAfterResult = await singleSearchAfter(
searchAfterSortId,
sampleParams,
Expand Down Expand Up @@ -322,19 +274,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn(),
fatal: jest.fn(),
log: jest.fn(),
};
try {
await singleSearchAfter(searchAfterSortId, sampleParams, mockService, mockLogger);
} catch (exc) {
Expand Down Expand Up @@ -380,23 +319,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
expect(logString).toEqual('something');
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
expect(logString).toEqual('something');
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
const result = await searchAfterAndBulkIndex(
sampleDocSearchResultsWithSortId,
sampleParams,
Expand Down Expand Up @@ -442,23 +364,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
expect(logString).toEqual('something');
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
expect(logString).toEqual('something');
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
const result = await searchAfterAndBulkIndex(
repeatedSearchResultsWithSortId(4),
sampleParams,
Expand All @@ -485,22 +390,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
expect(logString).toEqual('[-] bulkResponse had errors: true');
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
const result = await searchAfterAndBulkIndex(
repeatedSearchResultsWithSortId(4),
sampleParams,
Expand Down Expand Up @@ -546,22 +435,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
expect(logString).toEqual('sortIds was empty on first search but expected more');
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
const result = await searchAfterAndBulkIndex(
sampleDocSearchResultsNoSortId,
sampleParams,
Expand Down Expand Up @@ -607,22 +480,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
expect(logString).toEqual('sortIds was empty on first search but expected more');
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
const result = await searchAfterAndBulkIndex(
sampleDocSearchResultsNoSortIdNoHits,
sampleParams,
Expand Down Expand Up @@ -667,22 +524,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
expect(logString).toEqual('sortIds was empty on search');
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
const result = await searchAfterAndBulkIndex(
repeatedSearchResultsWithSortId(4),
sampleParams,
Expand Down Expand Up @@ -741,23 +582,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
// expect(logString).toEqual('something');
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
// expect(logString).toEqual('[-] bulk index failed');
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
const result = await searchAfterAndBulkIndex(
repeatedSearchResultsWithSortId(4),
sampleParams,
Expand Down Expand Up @@ -803,21 +627,6 @@ describe('utils', () => {
alertInstanceFactory: jest.fn(),
savedObjectsClient,
};
const mockLogger: Logger = {
info: jest.fn((logString: string) => {
return logString;
}),
warn: jest.fn((logString: string) => {
return logString;
}),
trace: jest.fn(),
debug: jest.fn(),
error: jest.fn((logString: string) => {
return logString;
}),
fatal: jest.fn(),
log: jest.fn(),
};
const result = await searchAfterAndBulkIndex(
repeatedSearchResultsWithSortId(4),
sampleParams,
Expand Down

0 comments on commit 6941907

Please sign in to comment.