Skip to content

Commit

Permalink
[Uptime] Temporarily skip flakey tests (#54675)
Browse files Browse the repository at this point in the history
* [Uptime] Temporarily skip flakey tests

* Fix further flakey tests due to hardcoding times + using snapshots
  • Loading branch information
andrewvc authored and brianseeders committed Jan 14, 2020
1 parent e5c17fb commit 72dd68e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { renderWithIntl } from 'test_utils/enzyme_helpers';
import { MonitorLocation } from '../../../../../common/runtime_types/monitor';
import { LocationStatusTags } from '../';

// These tests use absolute time
// Failing: https://github.com/elastic/kibana/issues/54672
describe.skip('StatusByLocation component', () => {
let monitorLocations: MonitorLocation[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { renderWithIntl } from 'test_utils/enzyme_helpers';
import { MonitorLocation } from '../../../../../common/runtime_types';
import { StatusByLocations } from '../';

describe('StatusByLocation component', () => {
describe.skip('StatusByLocation component', () => {
let monitorLocations: MonitorLocation[];

it('renders when up in all locations', () => {
Expand Down
6 changes: 4 additions & 2 deletions x-pack/test/functional/apps/uptime/overview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ export default ({ getPageObjects }: FtrProviderContext) => {
]);
});

it('pagination is cleared when filter criteria changes', async () => {
// flakey see https://github.com/elastic/kibana/issues/54527
it.skip('pagination is cleared when filter criteria changes', async () => {
await pageObjects.uptime.goToUptimePageAndSetDateRange(DEFAULT_DATE_START, DEFAULT_DATE_END);
await pageObjects.uptime.changePage('next');
// there should now be pagination data in the URL
Expand Down Expand Up @@ -86,7 +87,8 @@ export default ({ getPageObjects }: FtrProviderContext) => {
]);
});

describe('snapshot counts', () => {
// Flakey, see https://github.com/elastic/kibana/issues/54541
describe.skip('snapshot counts', () => {
it('updates the snapshot count when status filter is set to down', async () => {
await pageObjects.uptime.goToUptimePageAndSetDateRange(
DEFAULT_DATE_START,
Expand Down

0 comments on commit 72dd68e

Please sign in to comment.