-
Notifications
You must be signed in to change notification settings - Fork 8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.9] [APM] Fix transaction action menu for trace explorer and depend…
…ency operations (#162213) (#162260) # Backport This will backport the following commits from `main` to `8.9`: - [[APM] Fix transaction action menu for trace explorer and dependency operations (#162213)](#162213) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2023-07-19T15:25:08Z","message":"[APM] Fix transaction action menu for trace explorer and dependency operations (#162213)\n\n### Before\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115\r\n\r\n### After\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec\r\n\r\n\r\nCloses #162175: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"a8f9f73e19c6f5b6826a6a8f7752059659a5142d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","backport:prev-minor","v8.10.0"],"number":162213,"url":"#162213 Fix transaction action menu for trace explorer and dependency operations (#162213)\n\n### Before\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115\r\n\r\n### After\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec\r\n\r\n\r\nCloses #162175: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"a8f9f73e19c6f5b6826a6a8f7752059659a5142d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#162213 Fix transaction action menu for trace explorer and dependency operations (#162213)\n\n### Before\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115\r\n\r\n### After\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec\r\n\r\n\r\nCloses #162175: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"a8f9f73e19c6f5b6826a6a8f7752059659a5142d"}}]}] BACKPORT-->
- Loading branch information
Showing
6 changed files
with
177 additions
and
7 deletions.
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
...ns/apm/ftr_e2e/cypress/e2e/read_only_user/dependency_operation/dependency_operation.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import url from 'url'; | ||
import { synthtrace } from '../../../../synthtrace'; | ||
import { opbeans } from '../../../fixtures/synthtrace/opbeans'; | ||
|
||
const start = '2021-10-10T00:00:00.000Z'; | ||
const end = '2021-10-10T00:15:00.000Z'; | ||
|
||
const dependencyOperationHref = url.format({ | ||
pathname: '/app/apm/dependencies/operation', | ||
query: { | ||
dependencyName: 'postgresql', | ||
spanName: 'SELECT * FROM product', | ||
environment: 'ENVIRONMENT_ALL', | ||
rangeFrom: start, | ||
rangeTo: end, | ||
}, | ||
}); | ||
|
||
describe('Dependency operation', () => { | ||
before(() => { | ||
synthtrace.index( | ||
opbeans({ | ||
from: new Date(start).getTime(), | ||
to: new Date(end).getTime(), | ||
}) | ||
); | ||
}); | ||
|
||
after(() => { | ||
synthtrace.clean(); | ||
}); | ||
|
||
beforeEach(() => { | ||
cy.loginAsViewerUser(); | ||
}); | ||
|
||
it('opens the action menu popup when clicking the investigate button', () => { | ||
cy.visitKibana(dependencyOperationHref); | ||
cy.getByTestSubj('apmActionMenuButtonInvestigateButton').click(); | ||
cy.getByTestSubj('apmActionMenuInvestigateButtonPopup'); | ||
}); | ||
}); |
47 changes: 47 additions & 0 deletions
47
...ck/plugins/apm/ftr_e2e/cypress/e2e/read_only_user/mobile/mobile_transaction_details.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import url from 'url'; | ||
import { synthtrace } from '../../../../synthtrace'; | ||
import { generateMobileData } from './generate_data'; | ||
|
||
const start = '2021-10-10T00:00:00.000Z'; | ||
const end = '2021-10-10T00:15:00.000Z'; | ||
|
||
const mobileTransactionDetailsPageHref = url.format({ | ||
pathname: '/app/apm/mobile-services/synth-android/transactions/view', | ||
query: { | ||
rangeFrom: start, | ||
rangeTo: end, | ||
transactionName: 'Start View - View Appearing', | ||
}, | ||
}); | ||
|
||
describe('Mobile transaction details page', () => { | ||
before(() => { | ||
synthtrace.index( | ||
generateMobileData({ | ||
from: new Date(start).getTime(), | ||
to: new Date(end).getTime(), | ||
}) | ||
); | ||
}); | ||
|
||
beforeEach(() => { | ||
cy.loginAsViewerUser(); | ||
}); | ||
|
||
after(() => { | ||
synthtrace.clean(); | ||
}); | ||
|
||
it('opens the action menu popup when clicking the investigate button', () => { | ||
cy.visitKibana(mobileTransactionDetailsPageHref); | ||
cy.getByTestSubj('apmActionMenuButtonInvestigateButton').click(); | ||
cy.getByTestSubj('apmActionMenuInvestigateButtonPopup'); | ||
}); | ||
}); |
51 changes: 51 additions & 0 deletions
51
x-pack/plugins/apm/ftr_e2e/cypress/e2e/read_only_user/trace_explorer/trace_explorer.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import url from 'url'; | ||
import { synthtrace } from '../../../../synthtrace'; | ||
import { opbeans } from '../../../fixtures/synthtrace/opbeans'; | ||
|
||
const start = '2021-10-10T00:00:00.000Z'; | ||
const end = '2021-10-10T00:15:00.000Z'; | ||
|
||
const traceExplorerHref = url.format({ | ||
pathname: '/app/apm/traces/explorer', | ||
query: { | ||
environment: 'ENVIRONMENT_ALL', | ||
rangeFrom: start, | ||
rangeTo: end, | ||
}, | ||
}); | ||
|
||
describe('Trace Explorer', () => { | ||
before(() => { | ||
synthtrace.index( | ||
opbeans({ | ||
from: new Date(start).getTime(), | ||
to: new Date(end).getTime(), | ||
}) | ||
); | ||
|
||
cy.updateAdvancedSettings({ | ||
'observability:apmTraceExplorerTab': true, | ||
}); | ||
}); | ||
|
||
after(() => { | ||
synthtrace.clean(); | ||
}); | ||
|
||
beforeEach(() => { | ||
cy.loginAsViewerUser(); | ||
}); | ||
|
||
it('opens the action menu popup when clicking the investigate button', () => { | ||
cy.visitKibana(traceExplorerHref); | ||
cy.getByTestSubj('apmActionMenuButtonInvestigateButton').click(); | ||
cy.getByTestSubj('apmActionMenuInvestigateButtonPopup'); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters