Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix transaction action menu for trace explorer and dependency operations #162213

Merged
merged 6 commits into from Jul 19, 2023
Merged

[APM] Fix transaction action menu for trace explorer and dependency operations #162213

merged 6 commits into from Jul 19, 2023

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Jul 19, 2023 •
edited by kibanamachine

Before

Screen.Recording.2023-07-19.at.09.44.31.mov

After

Screen.Recording.2023-07-19.at.09.40.54.mov

Closes #162175

@gbamparop gbamparop requested a review from a team as a code owner July 19, 2023 08:39
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gbamparop gbamparop changed the title [APM] Fix transaction action menu [APM] Fix transaction action menu for trace explorer and dependency operations Jul 19, 2023
kpatticha
kpatticha approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

Can we either write a test or make sure to include it in the test plan as the same bug hit us a few months ago?

@kpatticha
Copy link
Contributor

kpatticha commented Jul 19, 2023 •
edited

Screenshot 2023-07-19 at 11 00 58

it seems the problem appears here as well. I thought we have fixed that :(

sorenlouv
sorenlouv approved these changes Jul 19, 2023
View reviewed changes
...ugins/apm/ftr_e2e/cypress/e2e/read_only_user/dependency_operation/dependency_operation.cy.ts
cy.getByTestSubj('apmActionMenuButtonInvestigateButton').click();
cy.getByTestSubj('apmActionMenuInvestigateButtonPopup');
});
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

...ugins/apm/ftr_e2e/cypress/e2e/read_only_user/dependency_operation/dependency_operation.cy.ts
Comment on lines +12 to +13
const start = '2021-10-10T00:00:00.000Z';
const end = '2021-10-10T00:15:00.000Z';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: Almost every test generates 15min of data. I wonder if we should reduce it to 1 min, and only increase the time range where needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that this will reduce the execution time?

@gbamparop
Copy link
Contributor Author

Thanks for the quick fix.

Can we either write a test or make sure to include it in the test plan as the same bug hit us a few months ago?

Thanks, added cypress tests here

@gbamparop
Copy link
Contributor Author

gbamparop commented Jul 19, 2023 •
edited

Screenshot 2023-07-19 at 11 00 58 it seems the problem appears here as well. I thought we have fixed that :(

I've fixed this and added a test for mobile transaction details page in 6327c9d

@gbamparop gbamparop added the backport:prev-minor Backport to the previous minor version (i.e. one version back from main) label Jul 19, 2023
@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.6MB 3.6MB +226.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gbamparop gbamparop merged commit a8f9f73 into elastic:main Jul 19, 2023
23 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.9 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 162213

Questions ?

Please refer to the Backport tool documentation

@gbamparop gbamparop mentioned this pull request Jul 19, 2023
Merged
@gbamparop
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gbamparop added a commit to gbamparop/kibana that referenced this pull request Jul 19, 2023
@gbamparop
[APM] Fix transaction action menu for trace explorer and dependency o…
3e1831e 
…perations (elastic#162213)

### Before

https://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115

### After

https://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec

Closes elastic#162175

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a8f9f73)

# Conflicts:
#	x-pack/plugins/apm/public/components/shared/transaction_action_menu/sections.ts
#	x-pack/plugins/apm/public/components/shared/transaction_action_menu/transaction_action_menu.tsx
Ruhshan pushed a commit to Ruhshan/kibana that referenced this pull request Jul 19, 2023
@gbamparop @kibanamachine @Ruhshan
[APM] Fix transaction action menu for trace explorer and dependency o…
53ad485 
…perations (elastic#162213)

### Before

https://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115

### After

https://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec


Closes elastic#162175

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gbamparop added a commit that referenced this pull request Jul 20, 2023
@gbamparop
[8.9] [APM] Fix transaction action menu for trace explorer and depend…
7c5bbe6 
…ency operations (#162213) (#162260)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[APM] Fix transaction action menu for trace explorer and dependency
operations (#162213)](#162213)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Giorgos
Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2023-07-19T15:25:08Z","message":"[APM]
Fix transaction action menu for trace explorer and dependency operations
(#162213)\n\n###
Before\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115\r\n\r\n###
After\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec\r\n\r\n\r\nCloses
#162175:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"a8f9f73e19c6f5b6826a6a8f7752059659a5142d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","backport:prev-minor","v8.10.0"],"number":162213,"url":"#162213
Fix transaction action menu for trace explorer and dependency operations
(#162213)\n\n###
Before\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115\r\n\r\n###
After\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec\r\n\r\n\r\nCloses
#162175:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"a8f9f73e19c6f5b6826a6a8f7752059659a5142d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#162213
Fix transaction action menu for trace explorer and dependency operations
(#162213)\n\n###
Before\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115\r\n\r\n###
After\r\n\r\nhttps://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec\r\n\r\n\r\nCloses
#162175:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"a8f9f73e19c6f5b6826a6a8f7752059659a5142d"}}]}]
BACKPORT-->
@mistic mistic removed the v8.9.0 label Jul 25, 2023
@mistic mistic added the v8.9.1 label Jul 25, 2023
@mistic
Copy link
Member

mistic commented Jul 25, 2023

This PR didn't make it into the latest BC of 8.9.0. Updating the labels.

ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@gbamparop @kibanamachine
[APM] Fix transaction action menu for trace explorer and dependency o…
94bd00a 
…perations (elastic#162213)

### Before

https://github.com/elastic/kibana/assets/5831975/3fcceac7-6cf6-4060-972e-86fc4c799115

### After

https://github.com/elastic/kibana/assets/5831975/0eccce82-4ffc-4c9e-8f8f-baf89cfbccec


Closes elastic#162175

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@kpatticha kpatticha kpatticha approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) release_note:fix Team:APM All issues that need APM UI Team support v8.9.1 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Click on Investigate button in Operations page throws an error
8 participants
@gbamparop @elasticmachine @apmmachine @kpatticha @kibana-ci @kibanamachine @mistic @sorenlouv