fix lint errors

elastic · Nov 15, 2019 · a545eb6 · a545eb6
1 parent 8372210
commit a545eb6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/test/functional/page_objects/common_page.ts b/test/functional/page_objects/common_page.ts
@@ -120,7 +120,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
      */
     public async navigateToUrl(
       appName: string,
-      subUrl: string,
+      subUrl?: string,
       {
         basePath = '',
         ensureCurrentUrl = true,
@@ -162,7 +162,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
      */
     async navigateToActualUrl(
       appName: string,
-      hash: string,
+      hash?: string,
       {
         basePath = '',
         ensureCurrentUrl = true,
@@ -209,7 +209,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
       await retry.tryForTime(defaultTryTimeout * 3, async () => {
         let lastUrl = await retry.try(async () => {
           // since we're using hash URLs, always reload first to force re-render
-          const defaultIndex = await kibanaServer.uiSettings.getDefaultIndex();
+          await kibanaServer.uiSettings.getDefaultIndex();
           await CommonPage.navigateToUrlAndHandleAlert(appUrl, shouldAcceptAlert);
           await this.sleep(700);
           log.debug('returned from get, calling refresh');

diff --git a/x-pack/test/functional/apps/canvas/feature_controls/canvas_security.ts b/x-pack/test/functional/apps/canvas/feature_controls/canvas_security.ts
@@ -86,7 +86,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
       it(`allows a workpad to be created`, async () => {
         await PageObjects.common.navigateToActualUrl('canvas', 'workpad/create', {
           ensureCurrentUrl: true,
-          showLoginIfPrompted: false,
+          shouldLoginIfPrompted: false,
         });
 
         await PageObjects.canvas.expectAddElementButton();
@@ -98,7 +98,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
           'workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31',
           {
             ensureCurrentUrl: true,
-            showLoginIfPrompted: false,
+            shouldLoginIfPrompted: false,
           }
         );
 

diff --git a/...ional/apps/saved_objects_management/feature_controls/saved_objects_management_security.ts b/...ional/apps/saved_objects_management/feature_controls/saved_objects_management_security.ts
@@ -115,7 +115,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
             'kibana',
             '/management/kibana/objects/savedVisualizations/75c3e060-1e7c-11e9-8488-65449e65d0ed',
             {
-              loginIfPrompted: false,
+              shouldLoginIfPrompted: false,
             }
           );
         });
@@ -233,7 +233,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
             'kibana',
             '/management/kibana/objects/savedVisualizations/75c3e060-1e7c-11e9-8488-65449e65d0ed',
             {
-              loginIfPrompted: false,
+              shouldLoginIfPrompted: false,
             }
           );
           await testSubjects.existOrFail('savedObjectsEdit');
@@ -316,7 +316,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
             'kibana',
             '/management/kibana/objects/savedVisualizations/75c3e060-1e7c-11e9-8488-65449e65d0ed',
             {
-              loginIfPrompted: false,
+              shouldLoginIfPrompted: false,
               ensureCurrentUrl: false,
             }
           );